From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A768C12002 for ; Fri, 16 Jul 2021 17:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0168C61164 for ; Fri, 16 Jul 2021 17:16:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230439AbhGPRTI (ORCPT ); Fri, 16 Jul 2021 13:19:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230468AbhGPRTG (ORCPT ); Fri, 16 Jul 2021 13:19:06 -0400 Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F017BC06175F for ; Fri, 16 Jul 2021 10:16:07 -0700 (PDT) Received: by mail-oo1-xc29.google.com with SMTP id a17-20020a4ad5d10000b0290263c143bcb2so1174216oot.7 for ; Fri, 16 Jul 2021 10:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jWbVndvTFPt8BOcGSAnZdQeZBgwQ39VLXMDadBgw6kk=; b=kycsT8OTIWrycyqND/lL5jUMQFDjltZ92oujogdg2Ndlkp+0StM8kAIg7tLjtQfeG1 YtQp0RLCivg5nlV/zFSc1mTULVPHjZTq7Ex+9U/i2yTDKpEG7bpkN+bJ8s8tT1JaBqwM y2TLzY9HoTp/Uz4id24PK7R/mXY9Jq6r81ZebQ+l6yf4sVQAbW1lEdfkLQRpnnjyDDmt bgikzUbY3QcdoaR5eMFhAPwFnx5Vw+ejdfPoUKSNgoBP0WsPICAy2cHDBYAdl8Ac/wYr kP06C8cTP2tL3t0qMqlAqnL33Dxo7e9FDTC/AFaZehjspePkLl7z/2H0fI4s4//TTHjd wV8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jWbVndvTFPt8BOcGSAnZdQeZBgwQ39VLXMDadBgw6kk=; b=jvR5VNKFnnmlYtAwSqJh5qSk3YuDxqaHA9tS5eEAFPj/0CxkHfqw/ABYBwc8U8FEwp 0TswdWXNolTbPPIEKArunNzBSSuNHOKEuxO1Rq2c3n8/artxJ9Ksc2Gwab6cDfo0sG4g E2RZWx8VzSP2AT/O67CMztGrEomSvFX/2979+n80I9BslTKsZppllSTuYIxiiOfcW38W Z4bisteWWh/VqVJugWUH4InCOeBf9G8ZVYPGu9gWG2dXZoxzcNPy+LvQtak/9QwnydZR W0R+OS8r0JMoe7UdYzknrXvi1AaEIG7KMZOVrIVKZoR27jh8QFdvXFPSZs94TILkkpYW cRJQ== X-Gm-Message-State: AOAM5300Wbq6CX0YDcXsb02ox/u7HPDeUG+3kZg10/DNSlRqiaoXCyKp kaaNwwXQvbYQKV23t71Sbqg/YGnCG5PjvttZPscMtQ== X-Google-Smtp-Source: ABdhPJx9gk24ziK+bUUPctrm/fDAn5x21MphrWbNdm5y/1f6NtI1GUnsZkQdW2dgVWs4fHcFQbpBeYfuinN/+cxYnXU= X-Received: by 2002:a4a:956f:: with SMTP id n44mr8396820ooi.54.1626455767094; Fri, 16 Jul 2021 10:16:07 -0700 (PDT) MIME-Version: 1.0 References: <87a6mnzbx2.fsf_-_@disp2133> <87tukuw8a3.fsf@disp2133> In-Reply-To: <87tukuw8a3.fsf@disp2133> From: Marco Elver Date: Fri, 16 Jul 2021 19:15:55 +0200 Message-ID: Subject: Re: [PATCH 0/6] Final si_trapno bits To: "Eric W. Biederman" Cc: Arnd Bergmann , Florian Weimer , "David S. Miller" , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Peter Collingbourne , Dmitry Vyukov , Alexander Potapenko , sparclinux , linux-arch , Linux Kernel Mailing List , Linux API , kasan-dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Jul 2021 at 18:09, Eric W. Biederman wrote: > Marco Elver writes: > > On Thu, Jul 15, 2021 at 01:09PM -0500, Eric W. Biederman wrote: > >> As a part of a fix for the ABI of the newly added SIGTRAP TRAP_PERF a > >> si_trapno was reduced to an ordinary extention of the _sigfault case > >> of struct siginfo. > >> > >> When Linus saw the complete set of changes come in as a fix he requested > >> that the set of changes be trimmed down to just what was necessary to > >> fix the SIGTRAP TRAP_PERF ABI. > >> > >> I had intended to get the rest of the changes into the merge window for > >> v5.14 but I dropped the ball. > >> > >> I have made the changes to stop using __ARCH_SI_TRAPNO be per > >> architecture so they are easier to review. In doing so I found one > >> place on alpha where I used send_sig_fault instead of > >> send_sig_fault_trapno(... si_trapno = 0). That would not have changed > >> the userspace behavior but it did make the kernel code less clear. > >> > >> My rule in these patches is everywhere that siginfo layout calls > >> for SIL_FAULT_TRAPNO the code uses either force_sig_fault_trapno > >> or send_sig_fault_trapno. > >> > >> And of course I have rebased and compile tested Marco's compile time > >> assert patches. > >> > >> Eric > >> > >> > >> Eric W. Biederman (3): > >> signal/sparc: si_trapno is only used with SIGILL ILL_ILLTRP > >> signal/alpha: si_trapno is only used with SIGFPE and SIGTRAP TRAP_UNK > >> signal: Remove the generic __ARCH_SI_TRAPNO support > >> > >> Marco Elver (3): > >> sparc64: Add compile-time asserts for siginfo_t offsets > >> arm: Add compile-time asserts for siginfo_t offsets > >> arm64: Add compile-time asserts for siginfo_t offsets > > > > Nice, thanks for the respin. If I diffed it right, I see this is almost > > (modulo what you mentioned above) equivalent to: > > https://lore.kernel.org/linux-api/m1tuni8ano.fsf_-_@fess.ebiederm.org/ > > + what's already in mainline. It's only missing: > > > > signal: Verify the alignment and size of siginfo_t > > signal: Rename SIL_PERF_EVENT SIL_FAULT_PERF_EVENT for consistency > > > > Would this be appropriate for this series, or rather separately, or > > dropped completely? > > Appropriate I just overlooked them. Full series with the 2 patches just sent looks good to me. Thanks, -- Marco