* [PATCH] kernel: kcov: fix a typo in comment
@ 2021-03-23 6:23 tl455047
2021-03-23 6:45 ` Dmitry Vyukov
0 siblings, 1 reply; 6+ messages in thread
From: tl455047 @ 2021-03-23 6:23 UTC (permalink / raw)
To: dvyukov; +Cc: kasan-dev, linux-kernel, tl455047
Fixed a typo in comment.
Signed-off-by: tl455047 <tl445047925@gmail.com>
---
kernel/kcov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kcov.c b/kernel/kcov.c
index 80bfe71bbe13..6f59842f2caf 100644
--- a/kernel/kcov.c
+++ b/kernel/kcov.c
@@ -527,7 +527,7 @@ static int kcov_get_mode(unsigned long arg)
/*
* Fault in a lazily-faulted vmalloc area before it can be used by
- * __santizer_cov_trace_pc(), to avoid recursion issues if any code on the
+ * __sanitizer_cov_trace_pc(), to avoid recursion issues if any code on the
* vmalloc fault handling path is instrumented.
*/
static void kcov_fault_in_area(struct kcov *kcov)
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel: kcov: fix a typo in comment
2021-03-23 6:23 [PATCH] kernel: kcov: fix a typo in comment tl455047
@ 2021-03-23 6:45 ` Dmitry Vyukov
2021-03-23 22:32 ` Marco Elver
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Vyukov @ 2021-03-23 6:45 UTC (permalink / raw)
To: tl455047; +Cc: kasan-dev, LKML, Andrew Morton, Linux-MM
On Tue, Mar 23, 2021 at 7:24 AM tl455047 <tl445047925@gmail.com> wrote:
>
> Fixed a typo in comment.
>
> Signed-off-by: tl455047 <tl445047925@gmail.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
+Andrew, linux-mm as KCOV patches are generally merged into mm.
Thanks for the fix
> ---
> kernel/kcov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kcov.c b/kernel/kcov.c
> index 80bfe71bbe13..6f59842f2caf 100644
> --- a/kernel/kcov.c
> +++ b/kernel/kcov.c
> @@ -527,7 +527,7 @@ static int kcov_get_mode(unsigned long arg)
>
> /*
> * Fault in a lazily-faulted vmalloc area before it can be used by
> - * __santizer_cov_trace_pc(), to avoid recursion issues if any code on the
> + * __sanitizer_cov_trace_pc(), to avoid recursion issues if any code on the
> * vmalloc fault handling path is instrumented.
> */
> static void kcov_fault_in_area(struct kcov *kcov)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel: kcov: fix a typo in comment
2021-03-23 6:45 ` Dmitry Vyukov
@ 2021-03-23 22:32 ` Marco Elver
2021-03-24 23:03 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Marco Elver @ 2021-03-23 22:32 UTC (permalink / raw)
To: tl455047; +Cc: kasan-dev, Dmitry Vyukov, LKML, Andrew Morton, Linux-MM
On Tue, 23 Mar 2021 at 07:45, 'Dmitry Vyukov' via kasan-dev
<kasan-dev@googlegroups.com> wrote:
> On Tue, Mar 23, 2021 at 7:24 AM tl455047 <tl445047925@gmail.com> wrote:
> >
> > Fixed a typo in comment.
> >
> > Signed-off-by: tl455047 <tl445047925@gmail.com>
>
> Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
>
> +Andrew, linux-mm as KCOV patches are generally merged into mm.
>
> Thanks for the fix
FYI, I believe this code may not be accepted due to this:
"[...] It is imperative that all code contributed to the kernel be legitimately
free software. For that reason, code from anonymous (or pseudonymous)
contributors will not be accepted."
See Documentation/process/1.Intro.rst
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel: kcov: fix a typo in comment
2021-03-23 22:32 ` Marco Elver
@ 2021-03-24 23:03 ` Andrew Morton
2021-03-24 23:11 ` Marco Elver
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2021-03-24 23:03 UTC (permalink / raw)
To: Marco Elver; +Cc: tl455047, kasan-dev, Dmitry Vyukov, LKML, Linux-MM
On Tue, 23 Mar 2021 23:32:57 +0100 Marco Elver <elver@google.com> wrote:
> On Tue, 23 Mar 2021 at 07:45, 'Dmitry Vyukov' via kasan-dev
> <kasan-dev@googlegroups.com> wrote:
> > On Tue, Mar 23, 2021 at 7:24 AM tl455047 <tl445047925@gmail.com> wrote:
> > >
> > > Fixed a typo in comment.
> > >
> > > Signed-off-by: tl455047 <tl445047925@gmail.com>
> >
> > Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
> >
> > +Andrew, linux-mm as KCOV patches are generally merged into mm.
> >
> > Thanks for the fix
>
> FYI, I believe this code may not be accepted due to this:
>
> "[...] It is imperative that all code contributed to the kernel be legitimately
> free software. For that reason, code from anonymous (or pseudonymous)
> contributors will not be accepted."
>
> See Documentation/process/1.Intro.rst
Correct. I let this one pass because the patch is so minor. But yes,
a real name would be preferred, please.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel: kcov: fix a typo in comment
2021-03-24 23:03 ` Andrew Morton
@ 2021-03-24 23:11 ` Marco Elver
0 siblings, 0 replies; 6+ messages in thread
From: Marco Elver @ 2021-03-24 23:11 UTC (permalink / raw)
To: Andrew Morton; +Cc: tl455047, kasan-dev, Dmitry Vyukov, LKML, Linux-MM
On Thu, 25 Mar 2021 at 00:04, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 23 Mar 2021 23:32:57 +0100 Marco Elver <elver@google.com> wrote:
> > On Tue, 23 Mar 2021 at 07:45, 'Dmitry Vyukov' via kasan-dev
> > <kasan-dev@googlegroups.com> wrote:
> > > On Tue, Mar 23, 2021 at 7:24 AM tl455047 <tl445047925@gmail.com> wrote:
> > > >
> > > > Fixed a typo in comment.
> > > >
> > > > Signed-off-by: tl455047 <tl445047925@gmail.com>
> > >
> > > Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
> > >
> > > +Andrew, linux-mm as KCOV patches are generally merged into mm.
> > >
> > > Thanks for the fix
> >
> > FYI, I believe this code may not be accepted due to this:
> >
> > "[...] It is imperative that all code contributed to the kernel be legitimately
> > free software. For that reason, code from anonymous (or pseudonymous)
> > contributors will not be accepted."
> >
> > See Documentation/process/1.Intro.rst
>
> Correct. I let this one pass because the patch is so minor. But yes,
> a real name would be preferred, please.
I've just seen that the author sent
https://lkml.kernel.org/r/20210324071051.55229-1-tl445047925@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] kernel: kcov: fix a typo in comment
@ 2021-03-24 7:10 Tim Yang
0 siblings, 0 replies; 6+ messages in thread
From: Tim Yang @ 2021-03-24 7:10 UTC (permalink / raw)
To: dvyukov; +Cc: kasan-dev, linux-kernel, Tim Yang
Fix a typo in comment.
Signed-off-by: Tim Yang <tl445047925@gmail.com>
---
kernel/kcov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kcov.c b/kernel/kcov.c
index 80bfe71bbe13..6f59842f2caf 100644
--- a/kernel/kcov.c
+++ b/kernel/kcov.c
@@ -527,7 +527,7 @@ static int kcov_get_mode(unsigned long arg)
/*
* Fault in a lazily-faulted vmalloc area before it can be used by
- * __santizer_cov_trace_pc(), to avoid recursion issues if any code on the
+ * __sanitizer_cov_trace_pc(), to avoid recursion issues if any code on the
* vmalloc fault handling path is instrumented.
*/
static void kcov_fault_in_area(struct kcov *kcov)
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-24 23:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 6:23 [PATCH] kernel: kcov: fix a typo in comment tl455047
2021-03-23 6:45 ` Dmitry Vyukov
2021-03-23 22:32 ` Marco Elver
2021-03-24 23:03 ` Andrew Morton
2021-03-24 23:11 ` Marco Elver
2021-03-24 7:10 Tim Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).