linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marco Elver <elver@google.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Xiongchun duan <duanxiongchun@bytedance.com>
Subject: Re: [PATCH v2] mm: kfence: fix objcgs vector allocation
Date: Mon, 28 Mar 2022 20:57:32 +0200	[thread overview]
Message-ID: <CANpmjNMszqqOF6TA1RmE93=xRU9pA5oc4RBoAtS+sBWwvS5y4w@mail.gmail.com> (raw)
In-Reply-To: <CAMZfGtVkp+xCM3kgLHRNRFUs_fus0f3Ry_jFv8QaSWLfnkXREg@mail.gmail.com>

On Mon, 28 Mar 2022 at 17:54, Muchun Song <songmuchun@bytedance.com> wrote:
[...]
> > >
> > > Btw, how did you test this?
> > >
>
> I have tested it with syzkaller with the following configs.
> And I didn't find any issues.
>
> CONFIG_KFENCE=y
> CONFIG_KFENCE_SAMPLE_INTERVAL=10
> CONFIG_KFENCE_NUM_OBJECTS=2550
> CONFIG_KFENCE_DEFERRABLE=n
> CONFIG_KFENCE_STATIC_KEYS=y
> CONFIG_KFENCE_STRESS_TEST_FAULTS=0

Hmm, I would have expected that you have some definitive test case
that shows the issue, and with the patch the issue is gone. Were there
issues triggered by syzkaller w/o this patch?

Thanks,
-- Marco

  reply	other threads:[~2022-03-28 18:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 13:28 [PATCH v2] mm: kfence: fix objcgs vector allocation Muchun Song
2022-03-28 15:43 ` Marco Elver
2022-03-28 15:51   ` Muchun Song
2022-03-28 15:54     ` Muchun Song
2022-03-28 18:57       ` Marco Elver [this message]
2022-03-29  3:01         ` [External] " Muchun Song
2022-03-28 19:26 ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANpmjNMszqqOF6TA1RmE93=xRU9pA5oc4RBoAtS+sBWwvS5y4w@mail.gmail.com' \
    --to=elver@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=duanxiongchun@bytedance.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).