From: Marco Elver <elver@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: RCU vs data_race()
Date: Tue, 6 Jul 2021 10:44:46 +0200 [thread overview]
Message-ID: <CANpmjNNRAJ34KUF-1hWrP3F0Ooy4oi6kbH82WWpDxmVqVSj4SA@mail.gmail.com> (raw)
In-Reply-To: <YOQNgsS9Tjt4aDmG@hirez.programming.kicks-ass.net>
On Tue, 6 Jul 2021 at 10:00, Peter Zijlstra <peterz@infradead.org> wrote:
[...]
> In that case, would not an explicit: data_debug(addr) call (implemented
> by KASAN/KCSAN/whoever), which would report whatever knowledge they have
> about that address, be even more useful?
KCSAN/KASAN report data-races/memory errors as soon as they encounter
them, but before they do, cannot give you any more than that (metadata
if it exists, but not sure it can be interpreted in any useful way
before an error occurs).
But maybe I misunderstood. Is data_debug() meant to not return
anything and instead just be a "fake access"?
For those, we already have various existing primitives:
-- KCSAN: ASSERT_EXCLUSIVE_{ACCESS,WRITER}()
(https://www.kernel.org/doc/html/latest/dev-tools/kcsan.html#race-detection-beyond-data-races)
-- All sanitizers (KASAN & KCSAN right now): <linux/instrumented.h>:
instrument_*() calls, for generic explicit instrumentation.
-- For sanitizer-specific checks, there's everything else in
<linux/{kasan,kcsan}-checks.h>, but instrumented.h should be
preferred.
Thanks,
-- Marco
next prev parent reply other threads:[~2021-07-06 8:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 8:24 RCU vs data_race() Peter Zijlstra
2021-06-18 8:59 ` Marco Elver
2021-06-18 11:26 ` Peter Zijlstra
2021-06-18 20:48 ` Paul E. McKenney
2021-06-20 19:14 ` Peter Zijlstra
2021-06-20 21:01 ` Paul E. McKenney
2021-06-21 7:28 ` Peter Zijlstra
2021-06-21 13:37 ` Paul E. McKenney
2021-07-06 8:00 ` Peter Zijlstra
2021-07-06 8:44 ` Marco Elver [this message]
2021-07-06 10:33 ` Peter Zijlstra
2021-07-06 14:03 ` Paul E. McKenney
2021-07-06 8:37 ` Peter Zijlstra
2021-07-06 14:16 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANpmjNNRAJ34KUF-1hWrP3F0Ooy4oi6kbH82WWpDxmVqVSj4SA@mail.gmail.com \
--to=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).