From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE91C43461 for ; Sat, 1 May 2021 00:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8C11613E8 for ; Sat, 1 May 2021 00:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231205AbhEAAi1 (ORCPT ); Fri, 30 Apr 2021 20:38:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231173AbhEAAiZ (ORCPT ); Fri, 30 Apr 2021 20:38:25 -0400 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74BF7C06174A for ; Fri, 30 Apr 2021 17:37:34 -0700 (PDT) Received: by mail-oi1-x22a.google.com with SMTP id t24so14350220oic.10 for ; Fri, 30 Apr 2021 17:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iYQeAScJs1TpMXononV3fp1ygIDD0T/s8VaH8jvt3Xw=; b=BePQGXKejT78YB+1Qc5q1LCPNsGstYOV9R088g5QlShgvjvM6ixO0lzCO87W+2TSwp znK2jDTneTfQHKD5uXShgkoJJolm6Bz5N/EpZXuPhYTS6BFF5IkfvoX18p4FHyHQvY4+ hXJbJoQq26tEPkPvjcG2/98QNh45edHmhZWqhkxCTc7VTF2opNFtY1Z0MIXNPxlaHsjB ZMeloEw7ihZti5Zsu/oJYJLe0bQkNbe20ExgjOelN6ADUadC/pM+rBBH/kZzZq3ZkcwK nnnsu4CBGHT3agel86Jlryxeenvqys1N+5c46cXHYT0kybVbeCNf+vY4SGwCaTNp6m1H fBIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iYQeAScJs1TpMXononV3fp1ygIDD0T/s8VaH8jvt3Xw=; b=IQ7uDY5C4kkBGAE9zPPOJ5SFKt0zT1d3H58wt4Iv/GAgKFXLW0A52q+eBB5d8Lk0V7 XkH0H0V90swsVcfZSaLOwxp88/IX+1iI5wTmeMgZjxni1o8YIPsv/O7Jpgr2oFJph96h pAGAPbci9XEAN/g0YbxzY2s7MIAzuToUpvn2lP9x9JW/uQWoR8KbwKy5i+04DS73UsAb V3gGY+Ffgs6ZKGuJ7eAFHYsMd36vbgUkl9E/++/Sa9H9pRQ0fFLJoJsgiD52LAkNN0I1 K8cb/hzbb0FZqocR0TwkaUcFiNKs6H3aVEprrF/DcEXc0IaH8xqQBA+2M5kvtEcZSGy3 pXzQ== X-Gm-Message-State: AOAM530FlGoGmpfH4QpsbWIKNqG/Boa5ylyL5zki41dGNWONOJVy3LcV xwy1jIvw2b/SIIVCMpbfIMPDZgGqHrnxpbVGCbvynA== X-Google-Smtp-Source: ABdhPJxIo+BVTYzvdhNqfbqRCIwfel9igFlw7u9W4kJYtv5n3JP2YhvgynpMjQkCwdk9y9SzRO6wrc/4VyE8xKAg5N0= X-Received: by 2002:aca:408a:: with SMTP id n132mr6087597oia.70.1619829453704; Fri, 30 Apr 2021 17:37:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Sat, 1 May 2021 02:37:22 +0200 Message-ID: Subject: Re: [RFC][PATCH 0/3] signal: Move si_trapno into the _si_fault union To: "Eric W. Biederman" Cc: Arnd Bergmann , Florian Weimer , "David S. Miller" , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Peter Collingbourne , Dmitry Vyukov , Alexander Potapenko , sparclinux , linux-arch , Linux Kernel Mailing List , Linux API , kasan-dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 1 May 2021 at 01:48, Eric W. Biederman wrote: > > Well with 7 patches instead of 3 that was a little more than I thought > I was going to send. > > However that does demonstrate what I am thinking, and I think most of > the changes are reasonable at this point. > > I am very curious how synchronous this all is, because if this code > is truly synchronous updating signalfd to handle this class of signal > doesn't really make sense. > > If the code is not synchronous using force_sig is questionable. > > Eric W. Biederman (7): > siginfo: Move si_trapno inside the union inside _si_fault > signal: Implement SIL_FAULT_TRAPNO > signal: Use dedicated helpers to send signals with si_trapno set > signal: Remove __ARCH_SI_TRAPNO > signal: Rename SIL_PERF_EVENT SIL_FAULT_PERF_EVENT for consistency > signal: Factor force_sig_perf out of perf_sigtrap > signal: Deliver all of the perf_data in si_perf Thank you for doing this so quickly -- it looks much cleaner. I'll have a more detailed look next week and also run some tests myself. At a first glance, you've broken our tests in tools/testing/selftests/perf_events/ -- needs a s/si_perf/si_perf.data/, s/si_errno/si_perf.type/ Thanks! -- Marco