From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C371C4727D for ; Thu, 24 Sep 2020 11:55:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD11523600 for ; Thu, 24 Sep 2020 11:55:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KC3r+Mpt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbgIXLzK (ORCPT ); Thu, 24 Sep 2020 07:55:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727471AbgIXLzK (ORCPT ); Thu, 24 Sep 2020 07:55:10 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AC55C0613CE for ; Thu, 24 Sep 2020 04:55:10 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id 95so2809745ota.13 for ; Thu, 24 Sep 2020 04:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ztRBPPvDaKOY/eanG9V3sp2lDW4LO5Tox/N9KiU+s4o=; b=KC3r+MptjH/RTy/874CBDG3LrIXfP8feQfAP7+/hMMMj/ti8ELR6KiicqyT2j9kmNl c89a6PBl1YAx7bbrDpZyNXZyhdK5ikYEIaSwbEWQmmwElvCPxips6yC+c8Ay6AEsndDf iRbwt9rhwrrTNe1XfSbpjOYKZryKtm7Eneiq7JPsUbPsW5Ivjrik88zf2y+f3ExpS4yS wUqLwJBMbDHQ6TXzOVVHl+Mk7PeHPBIbOKJkI7jIvqmRtAMgVfFXBlc8VA3lPG2w7SQ4 IGJpuwjS4zIt1ijLDM0JeJ26vpi18keWgLQdMOQjUzYH1SlD9SKzLWiUOtBadyDYiMhQ i95g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ztRBPPvDaKOY/eanG9V3sp2lDW4LO5Tox/N9KiU+s4o=; b=Ku5zsGQrunRF3HGcKT/uXHyiK66K1OxcLot3dqQr9W6l2WsNwQY2Bv5XD5Yrdzmk6T EpD2iVNX0tA8S0pndpnDKoU2wh0Y4zsZ4+XejO5CX1REECsL66twHqa3T90qv+aC/2OY vYIeYpMeHEhV6iPhOkjnj8gFfK1UNfnqO6nkgfi9rQxIuPXvIRh2unvwiCb/XAIRcYBE Kkew/jUpjzYX99gD05Sznen4KSaSXP9PJenNta8TddyQh2cIsXfml5izUa+x+A3YKM+9 pCFkXqS78rhp4UDYq7nqUdmPBCCZMBAPAV/NWls/N/yY2sDItE8lEMQEXpDdySCYuncP Civg== X-Gm-Message-State: AOAM5311GLJHaDlIDYrGcFbXt6mOQny2KcIynv49Q9do2m6me2cTKSaA xLvMnrtPH5BGwFP/32ukD47ynaTEtDvUfpde3q1FZQ== X-Google-Smtp-Source: ABdhPJzEBQ4Ct/h1arzvWDi0y14t62r2NGPwfHNLNhHfWH4WnG/J9sJadnKxxKmmnRROfMojYyJ8YHirAvneUEUwmno= X-Received: by 2002:a9d:758b:: with SMTP id s11mr2619746otk.251.1600948508986; Thu, 24 Sep 2020 04:55:08 -0700 (PDT) MIME-Version: 1.0 References: <20200924040513.31051-1-walter-zh.wu@mediatek.com> In-Reply-To: From: Marco Elver Date: Thu, 24 Sep 2020 13:54:57 +0200 Message-ID: Subject: Re: [PATCH v4 3/6] kasan: print timer and workqueue stack To: Alexander Potapenko Cc: Walter Wu , Andrew Morton , Andrey Ryabinin , Dmitry Vyukov , Andrey Konovalov , Matthias Brugger , kasan-dev , Linux Memory Management List , LKML , Linux ARM , wsd_upstream , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Sep 2020 at 13:47, Alexander Potapenko wrote: > > On Thu, Sep 24, 2020 at 6:05 AM Walter Wu wrote: > > > > The aux_stack[2] is reused to record the call_rcu() call stack, > > timer init call stack, and enqueuing work call stacks. So that > > we need to change the auxiliary stack title for common title, > > print them in KASAN report. > > > > Signed-off-by: Walter Wu > > Suggested-by: Marco Elver > > Acked-by: Marco Elver > > Reviewed-by: Dmitry Vyukov > > Reviewed-by: Andrey Konovalov > > Cc: Andrey Ryabinin > > Cc: Alexander Potapenko > > --- > > > > v2: > > - Thanks for Marco suggestion. > > - We modify aux stack title name in KASAN report > > in order to print call_rcu()/timer/workqueue stack. > > > > --- > > mm/kasan/report.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > index 4f49fa6cd1aa..886809d0a8dd 100644 > > --- a/mm/kasan/report.c > > +++ b/mm/kasan/report.c > > @@ -183,12 +183,12 @@ static void describe_object(struct kmem_cache *cache, void *object, > > > > #ifdef CONFIG_KASAN_GENERIC > > if (alloc_info->aux_stack[0]) { > > - pr_err("Last call_rcu():\n"); > > + pr_err("Last potentially related work creation:\n"); > > This doesn't have to be a work creation (expect more callers of > kasan_record_aux_stack() in the future), so maybe change the wording > here to "Last potentially related auxiliary stack"? I suggested "work creation" as it's the most precise for what it is used for now. What other users do you have in mind in future that are not work creation?