From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CD9C43461 for ; Wed, 31 Mar 2021 12:34:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5710C61878 for ; Wed, 31 Mar 2021 12:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235458AbhCaMde (ORCPT ); Wed, 31 Mar 2021 08:33:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235399AbhCaMdL (ORCPT ); Wed, 31 Mar 2021 08:33:11 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6D34C061574 for ; Wed, 31 Mar 2021 05:33:10 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id k14-20020a9d7dce0000b02901b866632f29so18791496otn.1 for ; Wed, 31 Mar 2021 05:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G2AUmQQuU10DnwHLe3j88zasAy4fwJf13uqVDHeKF6c=; b=dMoq/sx5t1QGdWz5mTYVbtcbABRgM77PzP4Pt01l7AzVneg2FZGmwBCFUhIPg13pZ0 R619RV7rjyIwhw5y6lVdlrOdBwndHm4XiOVOHkGdmfWiebKt0dk4gJkSv+ZqujYccdk1 /Y9YUnUSj7EaYfCx4xSDb8WZXyAwY2BQYjCLWh/2BQ7A8YdPpd0RTCwD0ajhFfvFREy6 8KaYkaqq+Obvx6/ePJpZLkWM8F7nHI2VRFTELT4G7dijwVkjF7wjpCvxPW6gxRuAnniL UURsS9hiUCAws+mhBJ1hPy3MFGmAiuLzrd7NwoGC1DlVfrl/kvwiEwz4DVaEIK/NAQyY B5lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G2AUmQQuU10DnwHLe3j88zasAy4fwJf13uqVDHeKF6c=; b=Yjw6wf960NBCaYjW9lCgZmt2yv/pOQWkycbRs9RrvTsw749m7cBTIaOu0v0HG/P31P ZOM3PAregS68vUcVGNhrvNXoavFUMHeIREjzbzJBhILFFMXeM+b4Ik08cmX5mifp8DKk iT50aNC5Fli+2XgiRYseu5XMwPADXQUEQJaDDSvh7f+m8AExk+sISv7VsjJkvyNP+vdU x9OMD4UeN6Fy8Hmdy36Ob/GEfRSGtdGLZpdFWunttvlfanKfFVwR2EF3NdqE5QrS90Se +qw6fVEjPqWHNVZdD5SEAjCvcYUgB/NIbjtS2rEihaXVta3Hi5RAQVkfXcB9077h7eLU 7zdg== X-Gm-Message-State: AOAM5323yrrilkrta3n8KAxXEyQqFKBguydxReJkht7ivwIhSIqSnKob cC26fb7ZlQRAfTR9JSTgLKwQQDRyWlVxjQuDQ7jzkw== X-Google-Smtp-Source: ABdhPJx6YDqVXlG9dIvGvuotdIeqBs0jLh1oYI6fps8tuotAwF3xJLdVe9L4RGLJ/HPVeJgnUb4aEQgH994pcSTpmPk= X-Received: by 2002:a9d:5508:: with SMTP id l8mr2553279oth.233.1617193990006; Wed, 31 Mar 2021 05:33:10 -0700 (PDT) MIME-Version: 1.0 References: <20210324112503.623833-1-elver@google.com> <20210324112503.623833-7-elver@google.com> In-Reply-To: From: Marco Elver Date: Wed, 31 Mar 2021 14:32:58 +0200 Message-ID: Subject: Re: [PATCH v3 06/11] perf: Add support for SIGTRAP on perf events To: Peter Zijlstra Cc: Alexander Shishkin , Arnaldo Carvalho de Melo , Ingo Molnar , Jiri Olsa , Mark Rutland , Namhyung Kim , Thomas Gleixner , Alexander Potapenko , Al Viro , Arnd Bergmann , Christian Brauner , Dmitry Vyukov , Jann Horn , Jens Axboe , Matt Morehouse , Peter Collingbourne , Ian Rogers , kasan-dev , linux-arch , linux-fsdevel , LKML , "the arch/x86 maintainers" , "open list:KERNEL SELFTEST FRAMEWORK" , Oleg Nesterov , Jiri Olsa Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Mar 2021 at 14:07, Peter Zijlstra wrote: > (and we might already have a problem on some architectures where there > can be significant time between these due to not having > arch_irq_work_raise(), so ideally we ought to double check current in > your case) I missed this bit -- just to verify: here we want to check that event->ctx->task == current, in case the the irq_work runs when the current task has already been replaced. Correct? Thanks, -- Marco