From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC44C433F5 for ; Tue, 3 May 2022 07:43:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232426AbiECHq7 (ORCPT ); Tue, 3 May 2022 03:46:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230514AbiECHq5 (ORCPT ); Tue, 3 May 2022 03:46:57 -0400 Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8441B37BF6 for ; Tue, 3 May 2022 00:43:26 -0700 (PDT) Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-2f7bb893309so170949897b3.12 for ; Tue, 03 May 2022 00:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G4F9J/vN8tSN8jrLP9zOvBCiC+XRvEv+dkdWW7NWJIE=; b=jemBUzyTNt8gqs21UYjZoNdxfU+cp9TWiW1q0iax3DlGEAbY7xlCAfY4bUC7P3X6pK 04nmfrLNlv6zJLfpgo3edRkTCJfWsQYRi6SndpX/kyin2q3GGvDjOhAtgRofIS4LZ/Mg 9QxCb7OLGJPqy2Pokkm2lvA2Trf0j8FDBuhr1TguD8w8Pvsz8Fu63w+IQXsl7reHLEaP /c2remfX9g/x5khU2m2HrwZUbwxOljrybrm6aghnggp80OUBit+1wAdx6yiw8A8/HpLO De0oOx6sP9xD9UYU3YHtYbsv+4D9+KwLLwjxUojZ5ivoIJ4X7vygdoB5MpV7FAmvnqib MJpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G4F9J/vN8tSN8jrLP9zOvBCiC+XRvEv+dkdWW7NWJIE=; b=wXB0YCzVO8xgzCYZQdD8DTe9AceZCJ2FSFqtbLZLbhRaN3K39FxJJrTVKXuWFT0XHP Z2u2bEAos0j3Fv+0Xz8ZcHw9D06lUZn0frJVK7I8th2lNsvrFsVGtnxNFINN2PikkcRv 4JYi2Yaksxu+4ZDeL0ESvJACrUA4u5UucVyZtMAh1nmQoXH5Kjjvhl80ZuSf7AX5hpz9 y3U9RilP6rtvS77TfDhZ30iBsNNL4jHxuGmms33hoFYGSnKg+TWTumo6eekkBNzmadMG MHSTd/TVdKaEqbsGlymCYql0YwkWBxkIYFJJjHspFOuGxuWl4GtGkJU9W+S9qt6cH+PQ IOhw== X-Gm-Message-State: AOAM532PQiVb1zPnu5CB0RZaAJlviSP5/7mCQ5fPvMwXm5FaGSkimaQv Av1LfyjOphlJHYCjmJNvMBJD8fQuIqgen5QGn6YsmQ== X-Google-Smtp-Source: ABdhPJwRj8WrBGxMnhniDzry34cZen2tqr3v8q9LbIHdeHN3Oe0gtfYxAWk0kgpG1EsHA0p3OQWLFgC5/6173OGoVKA= X-Received: by 2002:a81:1495:0:b0:2f7:1ce7:f482 with SMTP id 143-20020a811495000000b002f71ce7f482mr14373555ywu.333.1651563805516; Tue, 03 May 2022 00:43:25 -0700 (PDT) MIME-Version: 1.0 References: <87fslup9dx.fsf@jogness.linutronix.de> <87czgwmgtc.fsf@jogness.linutronix.de> In-Reply-To: <87czgwmgtc.fsf@jogness.linutronix.de> From: Marco Elver Date: Tue, 3 May 2022 09:42:49 +0200 Message-ID: Subject: Re: [next] i386: kunit: ASSERTION FAILED at mm/kfence/kfence_test.c:547 To: John Ogness Cc: Petr Mladek , Naresh Kamboju , Linux-Next Mailing List , open list , lkft-triage@lists.linaro.org, linux-mm , Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Stephen Rothwell , Anders Roxell , Andrey Konovalov , Andrey Ryabinin , Catalin Marinas , Evgenii Stepanov , Mark Rutland , Peter Collingbourne , Vincenzo Frascino , Will Deacon Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 May 2022 at 11:20, John Ogness wrote: > > On 2022-05-02, Petr Mladek wrote: > >> My proposal would be to fix the tracepoint like so: [...] > >> This fixes the KFENCE and KCSAN tests. > >> > >> Unless I hear objections, I'll prepare a patch explaining why we need to > >> fix the tracepoint. > > > > It makes perfect sense to me. > > This is the easiest place for it. However, it should be clear that in > the context of trace_console_rcuidle(), the message is not yet visible > to any readers. The message _will_ get committed and definitely _will_ > become visible at some point. But it is not (yet) visible at _this_ > point. Maybe that is OK for what it is being used for. > > If trace_console_rcuidle() must be called at the point of visibility for > readers, it becomes more complicated. I think that wasn't the original intent, so fixing it up to actually happen on printk() is probably the sanest thing. I sent the patch trying to explain: https://lore.kernel.org/all/20220503073844.4148944-1-elver@google.com/ Thank you both for the valuable pointers! -- Marco > John