From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F95BC433E7 for ; Mon, 12 Oct 2020 11:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0DFA214D8 for ; Mon, 12 Oct 2020 11:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WNwNfCC2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388220AbgJLL2z (ORCPT ); Mon, 12 Oct 2020 07:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388160AbgJLL2y (ORCPT ); Mon, 12 Oct 2020 07:28:54 -0400 Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F0D1C0613CE for ; Mon, 12 Oct 2020 04:28:54 -0700 (PDT) Received: by mail-oo1-xc43.google.com with SMTP id c10so612032oon.6 for ; Mon, 12 Oct 2020 04:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+XBDGrLSwB/6Y+76sReBKVonEBADxfEIwAHgLXgJVMM=; b=WNwNfCC2ACvhv6Pa/bsQsYh4kkbVFDdT5MQQONrFzL2gwX2MnK1rrG1hTLm2LOiffa SQNwSmdAuo7yfROtUrQKfzrgiyTB/OedKABr7BcetNgeA9/21HUAr5fvxqxBIF9BdvGF vTgCZRXUVz3zUO6A0eUpkN4bYxvqxZa4c4JKHwV2amoJLfuMy48tIJ1PLvPi2Fec8av0 3IPFllGnuCE8yt8J8sDzBxSGKNyTU0x4sgH0xJCnIkGjwklwaZ//LqiA76vGJudwFaUK uPBFzsKZlcfkVQg7JnhB0Mpt6tT0RpU1t0YIMdzjrtYA5y2vzpw3cSpDZEg4VJnRNf6e PeWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+XBDGrLSwB/6Y+76sReBKVonEBADxfEIwAHgLXgJVMM=; b=hRfc7wxWo+nk/egs3/rNQdskjRzMkK9S380X+muQ5yH3zsQCMLiwouVqJWX95C9+mu IHD1Y40rrcAmHEkvScn/LtITB/ycyJ/YfY0vc6ZqzFugtHpT+EesWfjRK71MgnBEgwcf KHwX2UCNLA1vSVwzn0GcVBaIzc/fTDU+Rxap2RD9JtbSOcbFWHqC+GkbIV5Z+VKVR39T bypTes5wtlhvcfqEXA+qKazp3Y2Cny18PTf+DwZo0Hp2PeK9/RwvAIG5iicGF/6QNeCS LWHFN5qz+s9434OllkDm7qVHLR2DN+zmY1yKMhFUSr7eG489dyWOOwNq8yojCENslwB+ W7qg== X-Gm-Message-State: AOAM531GTifwLRmHhuhcCKC6s4FFb8O/wtDcF2B3YLxqepePzgRgcFCx 56asgQWGXtxjsc64MXltUYBrBC1GIqH1UBhNU+E28w== X-Google-Smtp-Source: ABdhPJxsRy1faO20CsKmVxozicKRHXjn1dAMVKdnEGKL74LeSp9bzA6YqEnp2aHZxDujgJpSWMrKE9d4pcir8ovYK6w= X-Received: by 2002:a4a:db6f:: with SMTP id o15mr18181579ood.36.1602502133520; Mon, 12 Oct 2020 04:28:53 -0700 (PDT) MIME-Version: 1.0 References: <20201012105420.5945-1-sjpark@amazon.com> In-Reply-To: <20201012105420.5945-1-sjpark@amazon.com> From: Marco Elver Date: Mon, 12 Oct 2020 13:28:42 +0200 Message-ID: Subject: Re: [PATCH] Documentation: kunit: Update Kconfig parts for KUNIT's module support To: SeongJae Park Cc: Brendan Higgins , SeongJae Park , Jonathan Corbet , skhan@linuxfoundation.org, "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , "open list:DOCUMENTATION" , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Oct 2020 at 12:54, 'SeongJae Park' via KUnit Development wrote: > > From: SeongJae Park > > If 'CONFIG_KUNIT=m', letting kunit tests that do not support loadable > module build depends on 'KUNIT' instead of 'KUNIT=y' result in compile > errors. This commit updates the document for this. > > Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module") > Signed-off-by: SeongJae Park > --- > Documentation/dev-tools/kunit/start.rst | 2 +- > Documentation/dev-tools/kunit/usage.rst | 5 +++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/dev-tools/kunit/start.rst b/Documentation/dev-tools/kunit/start.rst > index d23385e3e159..454f307813ea 100644 > --- a/Documentation/dev-tools/kunit/start.rst > +++ b/Documentation/dev-tools/kunit/start.rst > @@ -197,7 +197,7 @@ Now add the following to ``drivers/misc/Kconfig``: > > config MISC_EXAMPLE_TEST > bool "Test for my example" > - depends on MISC_EXAMPLE && KUNIT > + depends on MISC_EXAMPLE && KUNIT=y > > and the following to ``drivers/misc/Makefile``: > > diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kunit/usage.rst > index 3c3fe8b5fecc..410380fc7fb4 100644 > --- a/Documentation/dev-tools/kunit/usage.rst > +++ b/Documentation/dev-tools/kunit/usage.rst > @@ -556,6 +556,11 @@ Once the kernel is built and installed, a simple > > ...will run the tests. > > +.. note:: > + Note that you should make your test depends on ``KUNIT=y`` in Kcofig if the > + test does not support module build. Otherwise, it will trigger compile > + errors if ``CONFIG_KUNIT`` is ``m``. s/Kcofig/Kconfig/ > Writing new tests for other architectures > ----------------------------------------- > > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups "KUnit Development" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20201012105420.5945-1-sjpark%40amazon.com.