From: Marco Elver <elver@google.com>
To: Alexander Potapenko <glider@google.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
Andrey Konovalov <andreyknvl@google.com>,
Dmitriy Vyukov <dvyukov@google.com>,
kasan-dev <kasan-dev@googlegroups.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Qian Cai <cai@lca.pw>
Subject: Re: [PATCH -rcu] kcsan: Make KCSAN compatible with lockdep
Date: Wed, 15 Jan 2020 17:26:55 +0100 [thread overview]
Message-ID: <CANpmjNP6+NTr7_rkNPVDbczst5vutW2K6FXXqkqFg6GGbQC31Q@mail.gmail.com> (raw)
In-Reply-To: <CAG_fn=X1rFGd1gfML3D5=uiLKTmMbPUm0UD6D0+bg+_hJtQMqA@mail.gmail.com>
On Tue, 14 Jan 2020 at 18:24, Alexander Potapenko <glider@google.com> wrote:
>
> > --- a/kernel/kcsan/core.c
> > +++ b/kernel/kcsan/core.c
> > @@ -337,7 +337,7 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type)
> > * detection point of view) to simply disable preemptions to ensure
> > * as many tasks as possible run on other CPUs.
> > */
> > - local_irq_save(irq_flags);
> > + raw_local_irq_save(irq_flags);
>
> Please reflect the need to use raw_local_irq_save() in the comment.
>
> >
> > watchpoint = insert_watchpoint((unsigned long)ptr, size, is_write);
> > if (watchpoint == NULL) {
> > @@ -429,7 +429,7 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type)
> >
> > kcsan_counter_dec(KCSAN_COUNTER_USED_WATCHPOINTS);
> > out_unlock:
> > - local_irq_restore(irq_flags);
> > + raw_local_irq_restore(irq_flags);
>
> Ditto
Done. v2: http://lkml.kernel.org/r/20200115162512.70807-1-elver@google.com
Thanks,
-- Marco
next prev parent reply other threads:[~2020-01-15 16:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 12:49 [PATCH -rcu] kcsan: Make KCSAN compatible with lockdep Marco Elver
2020-01-14 17:24 ` Alexander Potapenko
2020-01-15 16:26 ` Marco Elver [this message]
2020-01-15 16:37 ` Paul E. McKenney
2020-01-16 3:39 ` Qian Cai
2020-01-16 4:37 ` Qian Cai
2020-01-16 17:40 ` Paul E. McKenney
2020-01-16 17:50 ` Qian Cai
2020-01-16 17:55 ` Qian Cai
2020-01-16 18:57 ` Marco Elver
2020-01-17 16:40 ` Paul E. McKenney
2020-01-17 16:59 ` Qian Cai
2020-01-17 22:51 ` Marco Elver
2020-01-17 22:54 ` Marco Elver
2020-01-17 23:23 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANpmjNP6+NTr7_rkNPVDbczst5vutW2K6FXXqkqFg6GGbQC31Q@mail.gmail.com \
--to=elver@google.com \
--cc=andreyknvl@google.com \
--cc=cai@lca.pw \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).