From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 810A4C5DF62 for ; Wed, 6 Nov 2019 10:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4AC4A217F4 for ; Wed, 6 Nov 2019 10:24:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="J5KjDEJG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729500AbfKFKYG (ORCPT ); Wed, 6 Nov 2019 05:24:06 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:33679 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727239AbfKFKYG (ORCPT ); Wed, 6 Nov 2019 05:24:06 -0500 Received: by mail-ot1-f68.google.com with SMTP id u13so20421538ote.0 for ; Wed, 06 Nov 2019 02:24:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A9MmNy5B4ISbeBY94HhAkpv08cBgyWH2Yrx/6rMYgTw=; b=J5KjDEJGSzdkM1KTbWBEqmMmsFwht5dou90QcDgMqSekGHN42v8M+/lb6UJkRvgvGy IcBcMfaC5QdBBdteOmyZH2x0+N153Yqd53yLeGytsq4Ohedk1XWCkfmFwPo+Yv/1dyLn Gif27Ack2MoM5boHOSKtmOIGGtJu//QH4NtHZrO2rcVE4xBIjQ5MBkGX3+2ODAlKr5s+ /1iN0XkiLD5E9GDX/48CrU6B9/zhEorjwQ1g9wckfIYQkSf6MOoVBHCKKahb98ol1EBP ExJfaG31YX/gPVlsDhEK5QIXXFAIhszkOwJKQdIzbY/oVaKC8uzSrgQCbFfvatCAfWpO fMZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A9MmNy5B4ISbeBY94HhAkpv08cBgyWH2Yrx/6rMYgTw=; b=pwEmZGHZvzti41I2Q4HhRmIwyYaX4ak7dF6VOIUk5SaESk9DTweiZjfYah/2s0J1gt 6t56QNnpGoLJY3REstUMotXV6cbMovkeRQL7eZa12nF9X56c1XmPvAWTjUdRkgsmY+z4 G/EWL0E8c2GQAQfmJ1rpYf5NAuu5bJcs5yhhu4AUPixr/f6VMZlsvyz72Zv4+ISBztXY v04YlHABvpKScnbq05P2s/Xp2CoHR38asdDUWyhqiNs/e4o/AjfAxyv0nHnFzhmWkfA/ kLXXH8uZS2StqmRH30aJT2Fpga/es0CYZUxKkRR+azyX5Lf321rQ3uyQDPtSjCaxiu5T bkNw== X-Gm-Message-State: APjAAAV6RbLtibXE9aIcImF76QnIYPWOnYDMHiDAoTf9QwkOX4lnBzUr 6muyMrIsB4jYJGTTU+n8BMIHxRiKnC0tlSAenY0W9Q== X-Google-Smtp-Source: APXvYqyqr7mYctt9bjhQo4O23obVAeV7qCDkvVcBgq3vUhFxaJxhf8KbgfTJ3O7j6T/RL0XQEI0NqB1m6woKdhDGTlk= X-Received: by 2002:a05:6830:2308:: with SMTP id u8mr1245659ote.2.1573035844342; Wed, 06 Nov 2019 02:24:04 -0800 (PST) MIME-Version: 1.0 References: <0000000000009b403005942237bf@google.com> <27b57b11aadf1bd41ad8326101713ca0be7b8edf.camel@gmail.com> In-Reply-To: <27b57b11aadf1bd41ad8326101713ca0be7b8edf.camel@gmail.com> From: Marco Elver Date: Wed, 6 Nov 2019 11:23:52 +0100 Message-ID: Subject: Re: KCSAN: data-race in taskstats_exit / taskstats_exit To: Balbir Singh Cc: syzbot , LKML , syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Nov 2019 at 01:10, Balbir Singh wrote: > > On Fri, 2019-10-04 at 21:26 -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit: b4bd9343 x86, kcsan: Enable KCSAN for x86 > > git tree: https://github.com/google/ktsan.git kcsan > > console output: https://syzkaller.appspot.com/x/log.txt?x=125329db600000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=c0906aa620713d80 > > dashboard link: https://syzkaller.appspot.com/bug?extid=c5d03165a1bd1dead0c1 > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+c5d03165a1bd1dead0c1@syzkaller.appspotmail.com > > > > ================================================================== > > BUG: KCSAN: data-race in taskstats_exit / taskstats_exit > > > > write to 0xffff8881157bbe10 of 8 bytes by task 7951 on cpu 0: > > taskstats_tgid_alloc kernel/taskstats.c:567 [inline] > > taskstats_exit+0x6b7/0x717 kernel/taskstats.c:596 > > do_exit+0x2c2/0x18e0 kernel/exit.c:864 > > do_group_exit+0xb4/0x1c0 kernel/exit.c:983 > > get_signal+0x2a2/0x1320 kernel/signal.c:2734 > > do_signal+0x3b/0xc00 arch/x86/kernel/signal.c:815 > > exit_to_usermode_loop+0x250/0x2c0 arch/x86/entry/common.c:159 > > prepare_exit_to_usermode arch/x86/entry/common.c:194 [inline] > > syscall_return_slowpath arch/x86/entry/common.c:274 [inline] > > do_syscall_64+0x2d7/0x2f0 arch/x86/entry/common.c:299 > > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > > > read to 0xffff8881157bbe10 of 8 bytes by task 7949 on cpu 1: > > taskstats_tgid_alloc kernel/taskstats.c:559 [inline] > > taskstats_exit+0xb2/0x717 kernel/taskstats.c:596 > > do_exit+0x2c2/0x18e0 kernel/exit.c:864 > > do_group_exit+0xb4/0x1c0 kernel/exit.c:983 > > __do_sys_exit_group kernel/exit.c:994 [inline] > > __se_sys_exit_group kernel/exit.c:992 [inline] > > __x64_sys_exit_group+0x2e/0x30 kernel/exit.c:992 > > do_syscall_64+0xcf/0x2f0 arch/x86/entry/common.c:296 > > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > > > Sorry I've been away and just catching up with email > > I don't think this is a bug, if I interpret the report correctly it shows a > race > > static struct taskstats *taskstats_tgid_alloc(struct task_struct *tsk) > { > struct signal_struct *sig = tsk->signal; > struct taskstats *stats; > > #1 if (sig->stats || thread_group_empty(tsk)) <- the check of sig->stats > goto ret; > > /* No problem if kmem_cache_zalloc() fails */ > stats = kmem_cache_zalloc(taskstats_cache, GFP_KERNEL); > > spin_lock_irq(&tsk->sighand->siglock); > if (!sig->stats) { > #2 sig->stats = stats; <- here in setting sig->stats > stats = NULL; > } > spin_unlock_irq(&tsk->sighand->siglock); > > if (stats) > kmem_cache_free(taskstats_cache, stats); > ret: > return sig->stats; > } > > The worst case scenario is that we might see sig->stats as being NULL when two > threads belonging to the same tgid. We do free up stats if we got that wrong > > Am I misinterpreting the report? > > Balbir Singh. The plain concurrent reads/writes are a data race, which may manifest in various undefined behaviour due to compiler optimizations [1, 2]. Note that, "data race" does not necessarily imply "race condition"; some data races are race conditions (usually the more interesting bugs) -- but not *all* data races are race conditions (sometimes referred to as "benign races"). KCSAN reports data races according to the LKMM. [1] https://lwn.net/Articles/793253/ [2] https://lwn.net/Articles/799218/ If there is no race condition here that warrants heavier synchronization (locking etc.), we still have the data race which needs fixing by using marked atomic operations (READ_ONCE, WRITE_ONCE, atomic_t, etc.). We also need to consider memory ordering requirements (do we need smp_*mb(), smp_load_acquire/smp_store_release, ..)? In the case here, the pattern is double-checked locking, which is incorrect without atomic operations and the correct memory ordering. There is a lengthy discussion here: https://lore.kernel.org/lkml/20191021113327.22365-1-christian.brauner@ubuntu.com/ -- Marco