linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Curtin <ericcurtin17@gmail.com>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: align comments
Date: Wed, 10 Mar 2021 22:27:53 +0000	[thread overview]
Message-ID: <CANpvso71zHTHJBduzrX7wx=gDN9mi2CEaXskF=TaZZoL-2+V_Q@mail.gmail.com> (raw)
In-Reply-To: <20210310160946.GA6421@agape.jhs>

Hi Fabio,

> I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
> Where have I to add a ' ' (a blank?)?
>
> thank you,
>
> fabio
>

I'm only responding to this because this email is doing a very good job
of avoiding my filters somehow :) I think what Greg means is:

Change this:

 /*
-op_mode
-Set to 0 (HT pure) under the following conditions
-       - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
-       - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
-Set to 1 (HT non-member protection) if there may be non-HT STAs
-       in both the primary and the secondary channel
-Set to 2 if only HT STAs are associated in BSS,
-       however and at least one 20 MHz HT STA is associated
-Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
-       (currently non-GF HT station is considered as non-HT STA also)
-*/
+ *op_mode
+ *Set to 0 (HT pure) under the following conditions
+ *      - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
+ *      - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
+ *Set to 1 (HT non-member protection) if there may be non-HT STAs
+ *      in both the primary and the secondary channel
+ *Set to 2 if only HT STAs are associated in BSS,
+ *      however and at least one 20 MHz HT STA is associated
+ *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
+ *      (currently non-GF HT station is considered as non-HT STA also)
+ */

to this:

 /*
-op_mode
-Set to 0 (HT pure) under the following conditions
-       - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
-       - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
-Set to 1 (HT non-member protection) if there may be non-HT STAs
-       in both the primary and the secondary channel
-Set to 2 if only HT STAs are associated in BSS,
-       however and at least one 20 MHz HT STA is associated
-Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
-       (currently non-GF HT station is considered as non-HT STA also)
-*/
+ * op_mode
+ * Set to 0 (HT pure) under the following conditions
+ *      - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
+ *      - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
+ * Set to 1 (HT non-member protection) if there may be non-HT STAs
+ *      in both the primary and the secondary channel
+ * Set to 2 if only HT STAs are associated in BSS,
+ *      however and at least one 20 MHz HT STA is associated
+ * Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
+ *      (currently non-GF HT station is considered as non-HT STA also)
+ * /

Like Dan said, you need a space after the '*'/

Is mise le meas/Regards,

Eric Curtin

Check out this charity that's close to my heart:

https://www.idonate.ie/fundraiser/11394438_peak-for-pat.html
https://www.facebook.com/Peak-for-Pat-104470678280309
https://www.instagram.com/peakforpat/

  parent reply	other threads:[~2021-03-10 22:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 15:37 [PATCH] staging: rtl8723bs: align comments Fabio Aiuto
2021-03-10 15:51 ` Greg KH
2021-03-10 21:58   ` Fabio Aiuto
2021-03-10 22:13     ` Fabio Aiuto
2021-03-10 22:27     ` Eric Curtin [this message]
2021-03-10 22:45       ` Fabio Aiuto
2021-03-12  9:15       ` Fabio Aiuto
     [not found]     ` <CANiq72mEdHhJoCEmD0DD7QGP57soF3DGGoFNb89WF-4Oh_sscg@mail.gmail.com>
2021-03-11 13:31       ` Fabio Aiuto
2021-03-10 17:48 ` Dan Carpenter
2021-03-11  9:15   ` Joe Perches
2021-03-11 16:38     ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANpvso71zHTHJBduzrX7wx=gDN9mi2CEaXskF=TaZZoL-2+V_Q@mail.gmail.com' \
    --to=ericcurtin17@gmail.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).