linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] cirrus: add missing drm_connector_register call
Date: Fri, 19 Sep 2014 10:37:03 +0200	[thread overview]
Message-ID: <CANq1E4RUnO0VTSP++ONddAV1tiLOvQwGwxwzNZ3FvYnaObQdaA@mail.gmail.com> (raw)
In-Reply-To: <1411114297-13910-2-git-send-email-kraxel@redhat.com>

Hi

On Fri, Sep 19, 2014 at 10:11 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  drivers/gpu/drm/cirrus/cirrus_mode.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c
> index e1c5c32..c7c5a9d 100644
> --- a/drivers/gpu/drm/cirrus/cirrus_mode.c
> +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c
> @@ -555,6 +555,7 @@ static struct drm_connector *cirrus_vga_init(struct drm_device *dev)
>
>         drm_connector_helper_add(connector, &cirrus_vga_connector_helper_funcs);
>
> +       drm_connector_register(connector);

Error checking?

And should probably include "Cc: <stable@vger.kernel.org> # v3.15+".

Thanks
David

>         return connector;
>  }
>
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-09-19  8:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1411114297-13910-1-git-send-email-kraxel@redhat.com>
2014-09-19  8:11 ` [PATCH 1/2] cirrus: add missing drm_connector_register call Gerd Hoffmann
2014-09-19  8:37   ` David Herrmann [this message]
2014-09-19 10:19     ` Gerd Hoffmann
2014-09-19  8:11 ` [PATCH 2/2] bochs: " Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANq1E4RUnO0VTSP++ONddAV1tiLOvQwGwxwzNZ3FvYnaObQdaA@mail.gmail.com \
    --to=dh.herrmann@gmail.com \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).