From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084Ab2AQGha (ORCPT ); Tue, 17 Jan 2012 01:37:30 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:51306 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348Ab2AQGh2 convert rfc822-to-8bit (ORCPT ); Tue, 17 Jan 2012 01:37:28 -0500 MIME-Version: 1.0 In-Reply-To: References: <20120116184527.GA11972@kroah.com> <20120116184518.205969311@clark.kroah.org> Date: Tue, 17 Jan 2012 07:37:27 +0100 Message-ID: Subject: Re: [29/48] HID: wiimote: Select INPUT_FF_MEMLESS From: David Herrmann To: Paul Gortmaker Cc: Greg KH , linux-kernel@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Jiri Kosina Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2012 at 2:55 AM, Paul Gortmaker wrote: > On Mon, Jan 16, 2012 at 1:44 PM, Greg KH wrote: >> 3.1-stable review patch.  If anyone has any objections, please let me know. > > This one looks like typical patch Makefile/Kconfig "oh, hey this fits anywhere" > nonsense, and is completely broken.  Original was for a Wiimote, not Wacom. > Could someone explain to me where this came from? I cannot remember writing this patch. I wrote this one: http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=ef6f41157f3864d9bf42671b2ed66062dcafb72e I don't know where you got this "From" line? Regards David > >> >> ------------------ >> >> From: David Herrmann >> >> commit ef6f41157f3864d9bf42671b2ed66062dcafb72e upstream. >> >> We depend on memless force-feedback support, therefore correctly select the >> related config options. >> >> Reported-by: Randy Dunlap >> Signed-off-by: David Herrmann >> Signed-off-by: Jiri Kosina >> Signed-off-by: Greg Kroah-Hartman >> >> --- >>  drivers/hid/Kconfig |    1 + >>  1 file changed, 1 insertion(+) >> >> --- a/drivers/hid/Kconfig >> +++ b/drivers/hid/Kconfig >> @@ -583,6 +583,7 @@ config HID_WACOM_POWER_SUPPLY >>        bool "Wacom Bluetooth devices power supply status support" >>        depends on HID_WACOM >>        select POWER_SUPPLY >> +       select INPUT_FF_MEMLESS >>        ---help--- >>          Say Y here if you want to enable power supply status monitoring for >>          Wacom Bluetooth devices. >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at  http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at  http://www.tux.org/lkml/