From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755363Ab3F1KDP (ORCPT ); Fri, 28 Jun 2013 06:03:15 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:42922 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755130Ab3F1KDN (ORCPT ); Fri, 28 Jun 2013 06:03:13 -0400 MIME-Version: 1.0 In-Reply-To: <51CB5176.5000404@wwwdotorg.org> References: <1372112849-670-1-git-send-email-dh.herrmann@gmail.com> <1372112849-670-2-git-send-email-dh.herrmann@gmail.com> <51CB5176.5000404@wwwdotorg.org> Date: Fri, 28 Jun 2013 12:03:11 +0200 Message-ID: Subject: Re: [RFC 1/6] fbdev: simplefb: add init through platform_data From: David Herrmann To: Stephen Warren Cc: "dri-devel@lists.freedesktop.org" , linux-kernel , Dave Airlie , linux-fbdev@vger.kernel.org, Stephen Warren , Olof Johansson Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Wed, Jun 26, 2013 at 10:39 PM, Stephen Warren wrote: > On 06/24/2013 04:27 PM, David Herrmann wrote: >> If we create proper platform-devices in x86 boot-code, we can use simplefb >> for VBE or EFI framebuffers, too. However, there is normally no OF support >> so we introduce a platform_data object so x86 boot-code can pass the >> paramaters via plain old platform-data. >> >> This also removes the OF dependency as it is not needed. The headers >> provide proper dummies for the case OF is disabled. >> >> Furthermore, we move the FORMAT-definitions to the common platform header >> so initialization code can use it to transform "struct screen_info" to >> the right format-name. > >> diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h > >> +/* the framebuffer size and location is available as IORESOURCE_MEM */ >> +struct simplefb_platform_data { >> + u32 width; >> + u32 height; >> + u32 stride; >> + char format[64]; >> +}; > > Any reason not to make format: > > const char *format; > > You should be able to initialize that just as easily in platform code, > either as static data or at runtime, I think. That makes sense. I fixed it up. Thanks David