From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756200AbcFHIHl (ORCPT ); Wed, 8 Jun 2016 04:07:41 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:36675 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754382AbcFHIHc (ORCPT ); Wed, 8 Jun 2016 04:07:32 -0400 MIME-Version: 1.0 In-Reply-To: <10108662.fYf10pMtGa@avalon> References: <20160607033918.28687.98260.sendpatchset@little-apple> <20160607033945.28687.70956.sendpatchset@little-apple> <10108662.fYf10pMtGa@avalon> From: Magnus Damm Date: Wed, 8 Jun 2016 17:07:30 +0900 Message-ID: Subject: Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code To: Laurent Pinchart Cc: iommu@lists.linux-foundation.org, Laurent Pinchart , Geert Uytterhoeven , joro , linux-kernel , linux-renesas-soc@vger.kernel.org, Simon Horman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On Wed, Jun 8, 2016 at 9:18 AM, Laurent Pinchart wrote: > Hi Magnus, > > Thank you for the patch. > > On Tuesday 07 Jun 2016 12:39:45 Magnus Damm wrote: >> From: Magnus Damm >> >> Support the r8a7796 IPMMU by sharing feature flags between >> r8a7795 and r8a7796. Also update IOMMU_OF_DECLARE to hook >> up the updated compat string. >> >> Signed-off-by: Magnus Damm >> --- >> >> drivers/iommu/ipmmu-vmsa.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> --- 0031/drivers/iommu/ipmmu-vmsa.c >> +++ work/drivers/iommu/ipmmu-vmsa.c 2016-06-06 11:19:40.210607110 +0900 >> @@ -1074,7 +1074,7 @@ static const struct ipmmu_features ipmmu >> .twobit_imttbcr_sl0 = false, >> }; >> >> -static const struct ipmmu_features ipmmu_features_r8a7795 = { >> +static const struct ipmmu_features ipmmu_features_rcar_gen3 = { >> .use_ns_alias_offset = false, >> .has_cache_leaf_nodes = true, >> .has_eight_ctx = true, >> @@ -1088,7 +1088,10 @@ static const struct of_device_id ipmmu_o >> .data = &ipmmu_features_default, >> }, { >> .compatible = "renesas,ipmmu-r8a7795", >> - .data = &ipmmu_features_r8a7795, >> + .data = &ipmmu_features_rcar_gen3, >> + }, { >> + .compatible = "renesas,ipmmu-r8a7796", >> + .data = &ipmmu_features_rcar_gen3, >> }, { >> /* Terminator */ >> }, >> @@ -1268,6 +1271,8 @@ IOMMU_OF_DECLARE(ipmmu_vmsa_iommu_of, "r >> ipmmu_vmsa_iommu_of_setup); >> IOMMU_OF_DECLARE(ipmmu_r8a7795_iommu_of, "renesas,ipmmu-r8a7795", >> ipmmu_vmsa_iommu_of_setup); >> +IOMMU_OF_DECLARE(ipmmu_r8a7796_iommu_of, "renesas,ipmmu-r8a7796", >> + ipmmu_vmsa_iommu_of_setup); > > How about a Gen3 generic compatible string in addition to the SoC-specific > ones ? As you probably know, neither R-Car Gen2 nor R-Car Gen3 families are finished evolving. Because of that I find speculating with DT compat strings just potentially confusing with no apparent upside. Just going with what we know (ie the part number) is more than good enough IMO. Thanks, / magnus