From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757308AbbCCUsy (ORCPT ); Tue, 3 Mar 2015 15:48:54 -0500 Received: from na3sys009aog112.obsmtp.com ([74.125.149.207]:60164 "HELO na3sys009aog112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751441AbbCCUsx (ORCPT ); Tue, 3 Mar 2015 15:48:53 -0500 MIME-Version: 1.0 In-Reply-To: References: <1425350996-2930-1-git-send-email-joestringer@nicira.com> <20150303.143945.661201418308735762.davem@davemloft.net> From: Joe Stringer Date: Tue, 3 Mar 2015 12:40:16 -0800 Message-ID: Subject: Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions. To: David Miller Cc: Linux Netdev List , Pravin Shelar , Linux Kernel , Jarno Rajahalme Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3 March 2015 at 12:38, Joe Stringer wrote: > On 3 March 2015 at 11:39, David Miller wrote: >> From: Joe Stringer >> Date: Mon, 2 Mar 2015 18:49:56 -0800 >> >>> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside >>> of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions >>> back to regular set actions, the inner attribute length was not changed, >>> ie, double the length being serialized. This patch fixes the bug. >>> >>> Fixes: 83d2b9b ("net: openvswitch: Support masked set actions.") >>> Signed-off-by: Joe Stringer >>> --- >>> This fix needs to be applied to net as well; it applies cleanly. >> >> This is backwards, don't do this. Just say that 'net' needs the fix >> and submit it targetting that tree only. Things in 'net' propagate >> into 'net-next' automatically as I do merges over time, but the >> opposite is not true. > > OK, I'll resend. Nevermind, I see that you picked it up anyway. Thanks, I'll send fixes to the appropriate branch in future.