From: Joe Stringer <joestringer@nicira.com>
To: David Miller <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Pravin Shelar <pshelar@nicira.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Jarno Rajahalme <jrajahalme@nicira.com>
Subject: Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.
Date: Tue, 3 Mar 2015 12:38:54 -0800 [thread overview]
Message-ID: <CANr6G5zPg_RC=Dw=KD=AW4O4DY2j=Sc81SSYnfp8ZvyrkYOgLw@mail.gmail.com> (raw)
In-Reply-To: <20150303.143945.661201418308735762.davem@davemloft.net>
On 3 March 2015 at 11:39, David Miller <davem@davemloft.net> wrote:
> From: Joe Stringer <joestringer@nicira.com>
> Date: Mon, 2 Mar 2015 18:49:56 -0800
>
>> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside
>> of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions
>> back to regular set actions, the inner attribute length was not changed,
>> ie, double the length being serialized. This patch fixes the bug.
>>
>> Fixes: 83d2b9b ("net: openvswitch: Support masked set actions.")
>> Signed-off-by: Joe Stringer <joestringer@nicira.com>
>> ---
>> This fix needs to be applied to net as well; it applies cleanly.
>
> This is backwards, don't do this. Just say that 'net' needs the fix
> and submit it targetting that tree only. Things in 'net' propagate
> into 'net-next' automatically as I do merges over time, but the
> opposite is not true.
OK, I'll resend.
next prev parent reply other threads:[~2015-03-03 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 2:49 [PATCH net-next] openvswitch: Fix serialization of non-masked set actions Joe Stringer
2015-03-03 19:29 ` Jarno Rajahalme
2015-03-03 19:39 ` David Miller
2015-03-03 20:38 ` Joe Stringer [this message]
2015-03-03 20:40 ` Joe Stringer
2015-03-03 20:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANr6G5zPg_RC=Dw=KD=AW4O4DY2j=Sc81SSYnfp8ZvyrkYOgLw@mail.gmail.com' \
--to=joestringer@nicira.com \
--cc=davem@davemloft.net \
--cc=jrajahalme@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).