From: Byungchul Park <max.byungchul.park@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Byungchul Park <byungchul.park@lge.com>,
Ingo Molnar <mingo@kernel.org>, Tejun Heo <tj@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
david@fromorbit.com, Johannes Berg <johannes@sipsolutions.net>,
oleg@redhat.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-team@lge.com
Subject: Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation
Date: Fri, 1 Sep 2017 22:51:48 +0900 [thread overview]
Message-ID: <CANrsvRMc4QXnRFpYY1m7X+WU52WrC7HvvhbvAUqTWQTx2Py6bQ@mail.gmail.com> (raw)
In-Reply-To: <20170901123856.p2trpebau57yxftc@hirez.programming.kicks-ass.net>
On Fri, Sep 1, 2017 at 9:38 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Sep 01, 2017 at 07:16:29PM +0900, Byungchul Park wrote:
>
>> It would be gone _only_ at the time the history overrun, and then it
>> will be built again. So, you are wrong.
s/it will be built again/the acquisition will be added into the xhlock
array again/
Now, better to understand?
> How will it ever be build again? You only ever spawn the worker thread
> _ONCE_, then it runs lots and lots of works.
>
> We _could_ go fix it, but I really don't see it being worth the time and
We don't need to fix it spending time and effort. Just *revert* all your
wrong patches.
> effort, its a few isolated locks inside the kthread/workqueue code.
Please point out what I am wrong and what you want to say, *with* my
latest example. Doing it with my example would be very helpful to
understand you.
--
Thanks,
Byungchul
next prev parent reply other threads:[~2017-09-01 13:51 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 11:58 [PATCH 0/4] workqueue and lockdep stuffs Peter Zijlstra
2017-08-23 11:58 ` [PATCH 1/4] workqueue: Use TASK_IDLE Peter Zijlstra
2017-08-23 13:31 ` Tejun Heo
2017-08-23 11:58 ` [PATCH 2/4] lockdep/selftests: Add mixed read-write ABBA tests Peter Zijlstra
2017-08-23 11:58 ` [PATCH 3/4] workqueue/lockdep: Fix flush_work() annotation Peter Zijlstra
2017-08-23 11:58 ` [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation Peter Zijlstra
2017-08-24 2:18 ` Byungchul Park
2017-08-24 14:02 ` Peter Zijlstra
2017-08-25 1:11 ` Byungchul Park
2017-08-29 8:59 ` Peter Zijlstra
2017-08-29 14:23 ` [tip:locking/core] locking/lockdep: Untangle xhlock history save/restore from task independence tip-bot for Peter Zijlstra
2017-08-29 16:02 ` [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation Byungchul Park
2017-08-29 18:47 ` Peter Zijlstra
2017-08-30 2:09 ` Byungchul Park
2017-08-30 7:41 ` Byungchul Park
2017-08-30 8:53 ` Peter Zijlstra
2017-08-30 9:01 ` Byungchul Park
2017-08-30 9:12 ` Peter Zijlstra
2017-08-30 9:14 ` Peter Zijlstra
2017-08-30 9:35 ` Byungchul Park
2017-08-30 9:24 ` Byungchul Park
2017-08-30 11:25 ` Byungchul Park
2017-08-30 12:49 ` Byungchul Park
2017-08-31 7:26 ` Byungchul Park
2017-08-31 8:04 ` Peter Zijlstra
2017-08-31 8:15 ` Byungchul Park
2017-08-31 8:34 ` Peter Zijlstra
2017-09-01 2:05 ` Byungchul Park
2017-09-01 9:47 ` Peter Zijlstra
2017-09-01 10:16 ` Byungchul Park
2017-09-01 12:09 ` 박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com)
2017-09-01 12:38 ` Peter Zijlstra
2017-09-01 13:51 ` Byungchul Park [this message]
2017-09-01 16:38 ` Peter Zijlstra
2017-09-04 1:30 ` Byungchul Park
2017-09-04 2:08 ` Byungchul Park
2017-09-04 11:42 ` Peter Zijlstra
2017-09-05 0:38 ` Byungchul Park
2017-09-05 7:08 ` Peter Zijlstra
2017-09-05 7:19 ` Peter Zijlstra
2017-09-05 8:57 ` Byungchul Park
2017-09-05 9:36 ` Peter Zijlstra
2017-09-05 10:31 ` Byungchul Park
2017-09-05 10:52 ` Peter Zijlstra
2017-09-05 11:24 ` Byungchul Park
2017-09-05 10:58 ` Byungchul Park
2017-09-05 13:46 ` Peter Zijlstra
2017-09-05 23:52 ` Byungchul Park
2017-09-06 0:42 ` Boqun Feng
2017-09-06 1:32 ` Byungchul Park
2017-09-06 23:59 ` Byungchul Park
2017-09-07 0:11 ` Byungchul Park
2017-09-06 0:48 ` Byungchul Park
2017-09-05 8:30 ` Byungchul Park
2017-08-31 8:07 ` Peter Zijlstra
2017-08-25 4:39 ` Byungchul Park
2017-08-29 6:46 ` Byungchul Park
2017-08-29 9:01 ` Peter Zijlstra
2017-08-29 16:12 ` Byungchul Park
2017-08-23 13:32 ` [PATCH 0/4] workqueue and lockdep stuffs Tejun Heo
2017-08-23 13:45 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANrsvRMc4QXnRFpYY1m7X+WU52WrC7HvvhbvAUqTWQTx2Py6bQ@mail.gmail.com \
--to=max.byungchul.park@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=byungchul.park@lge.com \
--cc=david@fromorbit.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).