From: Stephen Zhang <starzhangzsd@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org,
zhangshida <zhangshida@kylinos.cn>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH] cgroup: fix potential null pointer risk
Date: Wed, 18 May 2022 09:04:12 +0800 [thread overview]
Message-ID: <CANubcdX7rvnWPd6BfLsHpchxCtmbg67mARHQbJXgpr6Ezkm1jQ@mail.gmail.com> (raw)
In-Reply-To: <YoPWWfoZ+6PrHuJl@slm.duckdns.org>
Tejun Heo <tj@kernel.org> 于2022年5月18日周三 01:07写道：
>
> The function is never called for a root cgroup. The parent check up above in
> the same function is superflous. So, maybe remove that?
>
> Thanks.
>
> --
> tejun
Thanks. I will remake a patch based on this.
--
Stephen
prev parent reply other threads:[~2022-05-18 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 7:31 [PATCH] cgroup: fix potential null pointer risk Shida Zhang
2022-05-17 17:07 ` Tejun Heo
2022-05-18 1:04 ` Stephen Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANubcdX7rvnWPd6BfLsHpchxCtmbg67mARHQbJXgpr6Ezkm1jQ@mail.gmail.com \
--to=starzhangzsd@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=zhangshida@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).