From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Lucas Tanure <tanure@linux.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Sasha Levin <sashal@kernel.org>, Jiri Kosina <jikos@kernel.org>,
linux-hyperv@vger.kernel.org,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: hyperv: NULL check before some freeing functions is not needed.
Date: Mon, 2 Mar 2020 11:16:30 +0100 [thread overview]
Message-ID: <CAO-hwJJDv=LnOQDbgWwg2sOccM9Tt-h=082Coi0aYdwG-CG-Kg@mail.gmail.com> (raw)
In-Reply-To: <20200229173007.61838-1-tanure@linux.com>
On Sat, Feb 29, 2020 at 6:30 PM Lucas Tanure <tanure@linux.com> wrote:
>
> Fix below warnings reported by coccicheck:
> drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed.
> drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed.
>
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Sasha, do you prefer taking this through your tree or through the HID
one. I don't think we have much scheduled for hyperv, so it's up to
you.
Cheers,
Benjamin
> drivers/hid/hid-hyperv.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index dddfca555df9..0b6ee1dee625 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -193,8 +193,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
> goto cleanup;
>
> /* The pointer is not NULL when we resume from hibernation */
> - if (input_device->hid_desc != NULL)
> - kfree(input_device->hid_desc);
> + kfree(input_device->hid_desc);
> input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);
>
> if (!input_device->hid_desc)
> @@ -207,8 +206,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
> }
>
> /* The pointer is not NULL when we resume from hibernation */
> - if (input_device->report_desc != NULL)
> - kfree(input_device->report_desc);
> + kfree(input_device->report_desc);
> input_device->report_desc = kzalloc(input_device->report_desc_size,
> GFP_ATOMIC);
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-03-02 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 17:30 [PATCH] HID: hyperv: NULL check before some freeing functions is not needed Lucas Tanure
2020-02-29 20:20 ` Michael Kelley
2020-02-29 22:48 ` Wei Liu
2020-03-02 10:16 ` Benjamin Tissoires [this message]
2020-03-02 12:09 ` Wei Liu
2020-03-04 14:48 ` Wei Liu
2020-03-04 14:55 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO-hwJJDv=LnOQDbgWwg2sOccM9Tt-h=082Coi0aYdwG-CG-Kg@mail.gmail.com' \
--to=benjamin.tissoires@redhat.com \
--cc=haiyangz@microsoft.com \
--cc=jikos@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tanure@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).