From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0B2C43334 for ; Wed, 13 Jul 2022 12:32:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235021AbiGMMcc (ORCPT ); Wed, 13 Jul 2022 08:32:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbiGMMc2 (ORCPT ); Wed, 13 Jul 2022 08:32:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0BFF2EABE8 for ; Wed, 13 Jul 2022 05:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657715547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bXRPU0M/Hx+9lHfOL9LxYIk0tOoUqE9PtXfSvp6NKH4=; b=hHxmyDMY7GxUsiFRW9Gf0Da5IpJzYty0dTTYiXpk7ft+hsZlxOLs+zVqPpdvjzDizwvrJA y59j4xAtQBkPVL5fb5m9CNkZ3mphd+twYjsk1tUCsht8CD6BSnqHvqxFW4hA1MRjnARdrJ eY0nsrwGCjvehVnvxOVVaeFvKxPLACc= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-382-FceSAsdwMQyfiSz9lEybRg-1; Wed, 13 Jul 2022 08:32:26 -0400 X-MC-Unique: FceSAsdwMQyfiSz9lEybRg-1 Received: by mail-pf1-f200.google.com with SMTP id f13-20020a056a001acd00b0052ab9ae76fbso3962665pfv.20 for ; Wed, 13 Jul 2022 05:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bXRPU0M/Hx+9lHfOL9LxYIk0tOoUqE9PtXfSvp6NKH4=; b=3fB3X772z1KhhLJqCtpM8677zfJPsR8HJxFTDvwBShqIt41Hwn1pXpmOAdVFT8p36i oBupBRYUjI32NjBVkPR/ocZljVN3srkyfJLedbDUbwiolHiRe+viTFtaZSHp8oaOy12k 2WBeZGNjLSsEcYwO1M+48dTDsgR7eTTbKQn+sn9EQwCMI7iKwQz1gIOSSmielddBGPhI lvPS6BDWpAR6c7jVtCZ9FhY+gSrTIuDyeeZeWeyF27VSrBoYURewVM5K2xeI1loQUKc5 btwbpKab5mKFuq6g62++wu1HHVbzYgI/WYe5uXITAFoy4bHhfb81TqvH5mSpOXvRQsaZ C7qw== X-Gm-Message-State: AJIora8xlkhHV/4c+Qh8i7VPyKNFvpIZa8dUqnpiLL/jSIeETzSImtw6 iyqkU79ogWywYLComhgD12sK4JWSbHmfBErKF2+k2jgEpeGVcq48DTJYseqG/484DVUouaot2tA 2oZA1ft8xK3QvdrxARYiVdIDckJ7q4mExIvRlh2sx X-Received: by 2002:a63:5b16:0:b0:416:1b3b:9562 with SMTP id p22-20020a635b16000000b004161b3b9562mr2825449pgb.146.1657715544982; Wed, 13 Jul 2022 05:32:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t9uWNYHyTapK2q1N1e3wCrLFwPd90gcSU2/P3W7avhJlby/nfPUHw1idL6GYPgQCA5GzKprWxsedAv0ocYYfA= X-Received: by 2002:a63:5b16:0:b0:416:1b3b:9562 with SMTP id p22-20020a635b16000000b004161b3b9562mr2825431pgb.146.1657715544728; Wed, 13 Jul 2022 05:32:24 -0700 (PDT) MIME-Version: 1.0 References: <20220712145850.599666-1-benjamin.tissoires@redhat.com> <20220712145850.599666-22-benjamin.tissoires@redhat.com> In-Reply-To: From: Benjamin Tissoires Date: Wed, 13 Jul 2022 14:32:13 +0200 Message-ID: Subject: Re: [PATCH bpf-next v6 21/23] samples/bpf: add new hid_mouse example To: Dominique Martinet Cc: Greg KH , Jiri Kosina , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Shuah Khan , Dave Marchevsky , Joe Stringer , Jonathan Corbet , Tero Kristo , lkml , "open list:HID CORE LAYER" , Networking , bpf , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Doc Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2022 at 2:16 PM Dominique Martinet wrote: > > Benjamin Tissoires wrote on Tue, Jul 12, 2022 at 04:58:48PM +0200: > > diff --git a/samples/bpf/hid_mouse.c b/samples/bpf/hid_mouse.c > > new file mode 100644 > > index 000000000000..f6e5f09026eb > > --- /dev/null > > +++ b/samples/bpf/hid_mouse.c > > @@ -0,0 +1,150 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* Copyright (c) 2022 Benjamin Tissoires > > + */ > > + > > +/* not sure why but this doesn't get preoperly imported */ > > typo: properly > > > +#define __must_check > > But more usefully, I don't think it should be needed -- we don't use > __must_check at all in uapi includes; if this is needed that means some > of the include here uses the kernel internal includes and that shouldn't > be needed as they're not normally installed. Indeed, I must have had the issue in the early days of development. Removing the line still makes the program compile, so I'll remove it in v7. Thanks a lot! Cheers, Benjamin > > Didn't actually try to see but taking the compilation line that fails > and running it with -E will probably show where that must_check comes > from > > -- > Dominique Martinet | Asmadeus, > just passing by >