From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE618C433E1 for ; Tue, 7 Jul 2020 12:41:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDC4720578 for ; Tue, 7 Jul 2020 12:41:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ASZqj2SM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728185AbgGGMlh (ORCPT ); Tue, 7 Jul 2020 08:41:37 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:24410 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727003AbgGGMlg (ORCPT ); Tue, 7 Jul 2020 08:41:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594125695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xciiD80zP1orEDkuFQaVx94y/jH2lWnyaNnhRi7uAHU=; b=ASZqj2SMP6w+W4QYGtBhc6KpmiHqnW0l2BjM1QtKKYvuAG3s/jjv5xGVJ6301QjQpk733T ZqKCRn5MLeDU/7ewsySRcNTD0AoNCSIf7vOAcQmJn4SyZQ7EJC7R3pjFZ4+4zGIYd6rs0A DTXntuOMg+2UGzH/FQLyb50IhQhGHEk= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-322-3o4bm8RBOKC3ySyvJJu2Zw-1; Tue, 07 Jul 2020 08:41:34 -0400 X-MC-Unique: 3o4bm8RBOKC3ySyvJJu2Zw-1 Received: by mail-qk1-f200.google.com with SMTP id i145so9581201qke.2 for ; Tue, 07 Jul 2020 05:41:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xciiD80zP1orEDkuFQaVx94y/jH2lWnyaNnhRi7uAHU=; b=uEa5Ik32qQDSyRSeHEiz/aDPAPXX8BHCwwnydKtVisYGVerJPkp+m+T6yBD/lAvdA1 rLyLTfKZDxkD5GiKzIa6FBeqNWQNBO0VgoK7yxF/aDQGULDtGq3Ra5jlK84WGxc9QEVU REoSxSwcUl1apKU3ueJYuIErnmnV6yyj4QtZUwJ0jcgHDiJsz5XRXK4qmGgGE4xVffco RXfqXBj0BTwBbfKuGZzjh5UGOmq9SvaWsSoSeXrxWC4VUdFaTf946KKDzBt0QoY2ZS9O 2TxhCIV2bM9Z06fISMk89jg2dPibj51RMNgLTLt7QUipuEB3FvtuxD3RVhaaCCu+JV4Z tDjg== X-Gm-Message-State: AOAM532vteCVD67bhJIoowRD73WZdyeLJ/hRPg1bBfgv4ZS7lzdo7irD v+nYAA0+0MWJh2S6+8YS/ZK7AJjU0Bc2Cp7taRI7p8wM0xJp9tHP5vgoXy4EiHMkBRw+yxDPiaY wW+BPYnUsghtGD3ppMGccqETzIZooxqPgMwvNf0/u X-Received: by 2002:a05:620a:22cc:: with SMTP id o12mr37883667qki.230.1594125693363; Tue, 07 Jul 2020 05:41:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyP6smbupZKAwsH82c9IuyMHurFxxfFL3lg3HgS+Yna+vRveJg4MbajXPTdHz1BfmCS75o3pP1vmieESGrBAqY= X-Received: by 2002:a05:620a:22cc:: with SMTP id o12mr37883645qki.230.1594125693077; Tue, 07 Jul 2020 05:41:33 -0700 (PDT) MIME-Version: 1.0 References: <20200626055936.4441-1-mail@mariuszachmann.de> <20200630021642.GA155878@roeck-us.net> In-Reply-To: From: Benjamin Tissoires Date: Tue, 7 Jul 2020 14:41:22 +0200 Message-ID: Subject: Re: [PATCH v7] hwmon: add Corsair Commander Pro driver To: Jiri Kosina Cc: Guenter Roeck , Marius Zachmann , Jean Delvare , linux-hwmon@vger.kernel.org, Linux Doc Mailing List , lkml , "open list:HID CORE LAYER" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 7, 2020 at 12:20 PM Jiri Kosina wrote: > > On Mon, 29 Jun 2020, Guenter Roeck wrote: > > > On Fri, Jun 26, 2020 at 07:59:36AM +0200, Marius Zachmann wrote: > > > This is v7 of a driver for the Corsair Commander Pro. > > > It provides sysfs attributes for: > > > - Reading fan speed > > > - Reading temp sensors > > > - Reading voltage values > > > - Writing pwm and reading last written pwm > > > - Reading fan and temp connection status > > > > > > It is an usb driver, so it needs to be ignored by usbhid. > > > The Corsair Commander Pro is a fan controller and provides > > > no means for user interaction. > > > The two device numbers are there, because there is a slightly > > > different version of the same device. (Only difference > > > seem to be in some presets.) > > > > > > This is based on the staging/hwmon tree. > > > > > > Signed-off-by: Marius Zachmann > > > > For my reference: > > > > Reviewed-by: Guenter Roeck > > > > Waiting for Ack from HID maintainer. > > Acked-by: Jiri Kosina Sorry I missed this too: Acked-by: Benjamin Tissoires for the HID hunk too. Cheers, Benjamin > > for the drivers/hid/hid-quirks.c hunk. Thanks, > > -- > Jiri Kosina > SUSE Labs >