From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Hanno Zulla <kontakt@hanno.de>
Cc: Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] HID: hid-bigbenff: fixing three crash bugs in a gamepad driver
Date: Wed, 19 Feb 2020 08:54:47 +0100 [thread overview]
Message-ID: <CAO-hwJL8cSJqG4TB6ZJiqoWr0RhV0zhMNK3qVwS6i9FmK7RCRA@mail.gmail.com> (raw)
In-Reply-To: <74d73ebc-0cff-768d-00b7-57bb9b44124f@hanno.de>
On Tue, Feb 18, 2020 at 12:44 PM Hanno Zulla <kontakt@hanno.de> wrote:
>
> Hi Benjamin,
>
> > I think the patches are correct (have you tested them with actual HW?).
>
> Yes, I did, and am also properly embarrassed that I didn't notice the
> double free bug in the original driver.
>
> > However, checkpatch complains that the From and Signed-off-by email
> > differ. Can you send a v2 with a fix for that?
>
> Here it is.
>
Thanks for the quick respin.
Not sure what happened, but the commit title was duplicated in all of
the commits.
Anyway, not a big deal, fixed and pushed to for-5.6/upstream-fixes
Cheers,
Benjamin
> Thanks,
>
> Hanno
>
prev parent reply other threads:[~2020-02-19 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 15:24 [PATCH 0/3] HID: hid-bigbenff: fixing three crash bugs in a gamepad driver Hanno Zulla
2020-02-17 15:25 ` [PATCH 1/3] HID: hid-bigbenff: fix general protection fault caused by double kfree Hanno Zulla
2020-02-17 15:26 ` [PATCH 2/3] HID: hid-bigbenff: call hid_hw_stop() in case of error Hanno Zulla
2020-02-17 15:27 ` [PATCH 3/3] HID: hid-bigbenff: fix race condition for scheduled work during removal Hanno Zulla
2020-02-18 10:40 ` [PATCH 0/3] HID: hid-bigbenff: fixing three crash bugs in a gamepad driver Benjamin Tissoires
2020-02-18 11:30 ` [PATCH v2 " Hanno Zulla
2020-02-18 11:37 ` [PATCH v2 1/3] HID: hid-bigbenff: fix general protection fault caused by double kfree Hanno Zulla
2020-02-18 11:38 ` [PATCH v2 2/3] HID: hid-bigbenff: call hid_hw_stop() in case of error Hanno Zulla
2020-02-18 11:39 ` [PATCH v2 3/3] HID: hid-bigbenff: fix race condition for scheduled work during removal Hanno Zulla
2020-02-19 7:54 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO-hwJL8cSJqG4TB6ZJiqoWr0RhV0zhMNK3qVwS6i9FmK7RCRA@mail.gmail.com \
--to=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=kontakt@hanno.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).