From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: acelan.kao@canonical.com, Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dtor@chromium.org>,
Aaron Ma <aaron.ma@canonical.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: i2c-hid: Fix flooded incomplete report after S3 on Rayd touchscreen
Date: Tue, 28 Aug 2018 14:38:18 +0200 [thread overview]
Message-ID: <CAO-hwJLfpYr6bmTH=rcSfET61599VoZp4uEJ7uY62R2dSSfn6A@mail.gmail.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1808281346150.25787@cbobk.fhfr.pm>
On Tue, Aug 28, 2018 at 1:46 PM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Tue, 21 Aug 2018, AceLan Kao wrote:
>
> > The incomplete report flooded after S3 and touchscreen becomes
> > malfunctioned.
> > [ 1367.646244] i2c_hid i2c-CUST0000:00: i2c_hid_get_input: incomplete report (58/18785)
> > [ 1367.649471] i2c_hid i2c-CUST0000:00: i2c_hid_get_input: incomplete report (58/28743)
> > [ 1367.651092] i2c_hid i2c-CUST0000:00: i2c_hid_get_input: incomplete report (58/26757)
> > [ 1367.652658] i2c_hid i2c-CUST0000:00: i2c_hid_get_input: incomplete report (58/52280)
> > [ 1367.654287] i2c_hid i2c-CUST0000:00: i2c_hid_get_input: incomplete report (58/56059)
> >
> > Adding device ID, 04F3:30CC, to the quirk to re-send report description
> > after resume.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
>
> Applied, thanks.
Just a quick note Jiri. Hans pointed me this morning to
https://bugzilla.redhat.com/show_bug.cgi?id=1622695
And I think we should apply the quirk unconditionally as it should be
safe to retrieve the HID descriptor at all times. I am planning on
working on that tomorrow or Thursday when I have access to the XPS
with i2c_hid devices attached to it.
Cheers,
Benjamin
>
> --
> Jiri Kosina
> SUSE Labs
>
prev parent reply other threads:[~2018-08-28 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 8:55 [PATCH] HID: i2c-hid: Fix flooded incomplete report after S3 on Rayd touchscreen AceLan Kao
2018-08-27 12:30 ` Benjamin Tissoires
2018-08-28 11:46 ` Jiri Kosina
2018-08-28 12:38 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO-hwJLfpYr6bmTH=rcSfET61599VoZp4uEJ7uY62R2dSSfn6A@mail.gmail.com' \
--to=benjamin.tissoires@redhat.com \
--cc=aaron.ma@canonical.com \
--cc=acelan.kao@canonical.com \
--cc=dtor@chromium.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).