From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 523C0C433DB for ; Wed, 13 Jan 2021 15:10:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 164812339F for ; Wed, 13 Jan 2021 15:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726828AbhAMPKY (ORCPT ); Wed, 13 Jan 2021 10:10:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28684 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbhAMPKX (ORCPT ); Wed, 13 Jan 2021 10:10:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610550536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kWipm+X2j1RbsimdpvIAl9U3K5QN86SQ19iK5SoxS1o=; b=STkhg0Pybd7hUHilPx5Zh89F671FWSeS9kQ/FP1UD64lIjIfT3mfwRXqiR7+MOfWUVaT80 a1ll+EXbFgFUQC5JgXpusFn4LGBYTQVixp1oFYl6egwtrG9w6G75tSoxesUK1BkhtVt/FQ 55Bd9QQbBrlWwtK07vOfSDyXicyCV9Q= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-7r4zH3TRPruaiOxfQJf_pQ-1; Wed, 13 Jan 2021 10:08:54 -0500 X-MC-Unique: 7r4zH3TRPruaiOxfQJf_pQ-1 Received: by mail-pf1-f198.google.com with SMTP id 15so1499850pfu.6 for ; Wed, 13 Jan 2021 07:08:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kWipm+X2j1RbsimdpvIAl9U3K5QN86SQ19iK5SoxS1o=; b=dzPYmj7k9MP2UuanBZU7g3fYFFLcR6QCPbVv1JAzDAPvK29s+LfP3IWgiwsIMIM48t p9F70NnBft2d6QAIRM/+xI6GSjEEv7Ia9nMNzkv05oF/WLUlln4UFriGNcvuKPj7J9LV /fysmcpFye4RK0vPJoa4QlMLePJiIgvLfADQwmeSTM/m0XgbvEywRsSS5LRSausCutb8 Uyb+Vnl181+OzjhOM+xQH9eMoyIoJM4+wiYRTFpuNP2Fsvjcok4tExKmjU1Wj6xowGnG bxEfc7QVt8qDJy4HRmCdPmA6CRRky1Tk4fDda5gixzE7XTvh2948fdzk1R0jEJU5Zamf aUrg== X-Gm-Message-State: AOAM531KN4IZWy/WJ3ULdombwXI60haeUMTGi8UL6Buk6O/IyAAzBmsj Ofh00OibRgYk9R89WL8JfvIoBgs8Bi+gClGYDaglWUBa0VZMRBIC1IXz/x8CaGpL8J9rHCoHeIp Ehi13pP0J+LeHBu4a/MqzJr6HS9ucmmK57Skmn6GU X-Received: by 2002:a63:4d41:: with SMTP id n1mr2439836pgl.147.1610550532830; Wed, 13 Jan 2021 07:08:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvxkW7BMeeEqiByfe7FaWReWauDte5vCp+7LTLQQFvoJcFAxS9Ug7HUmiUfgfocS9TC46d93Yz9Z3rprm9ksw= X-Received: by 2002:a63:4d41:: with SMTP id n1mr2439815pgl.147.1610550532579; Wed, 13 Jan 2021 07:08:52 -0800 (PST) MIME-Version: 1.0 References: <20201211222448.2115188-1-dianders@chromium.org> In-Reply-To: From: Benjamin Tissoires Date: Wed, 13 Jan 2021 16:08:41 +0100 Message-ID: Subject: Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p To: Doug Anderson Cc: Jiri Kosina , Greg Kroah-Hartman , Dmitry Torokhov , Hans de Goede , "open list:HID CORE LAYER" , Kai-Heng Feng , Rob Herring , Stephen Boyd , Andrea Borgia , Anson Huang , Bjorn Andersson , Catalin Marinas , Daniel Playfair Cal , Geert Uytterhoeven , =?UTF-8?Q?Guido_G=C3=BCnther?= , Jiri Kosina , Li Yang , Masahiro Yamada , Max Krummenacher , Michael Walle , Pavel Balan , Shawn Guo , Vinod Koul , Will Deacon , Xiaofei Tan , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 8, 2021 at 6:52 PM Benjamin Tissoires wrote: > > Hi Doug, > > On Wed, Jan 6, 2021 at 2:35 AM Doug Anderson wrote: > > > > Benjamin, > > > > On Fri, Dec 11, 2020 at 2:24 PM Douglas Anderson wrote: > > > > > > The goal of this series is to support the Goodix GT7375P touchscreen. > > > This touchscreen is special because it has power sequencing > > > requirements that necessitate driving a reset GPIO. > > > > > > To do this, we totally rejigger the way i2c-hid is organized so that > > > it's easier to jam the Goodix support in there. > > > > > > This series was: > > > - Tested on a device that uses normal i2c-hid. > > > - Tested on a device that has a Goodix i2c-hid device. > > > - Tested on an ACPI device, but an earlier version of the series. > > > > > > I believe the plan is for Benjamin to land the whole series. Will > > > said this about the arm64 defconfig change (and provided his Ack): > > > > ...there are a few things I really care about > > > > in defconfig (e.g. things like page size!), generally speaking we don't > > > > need to Ack everything that changes in there. > > > > > > > > That said, might be worth checking whether arm-soc have any defconfig > > > > changes queued in -next so you don't end up with conflicts. > > > > > > Changes in v8: > > > - Mark suspend/resume as static as per patches robot. > > > > > > Changes in v7: > > > - Rebase atop commit afdd34c5fa40 ("HID: i2c-hid: show the error ...") > > > > > > Changes in v6: > > > - ACPI probe function should have been "static" > > > - Don't export suspend/resume, just export dev_pm_ops from core. > > > - Fixed crash in ACPI module (missing init of "client") > > > - No need for regulator include in the core. > > > - Removed i2c_device_id table from ACPI module. > > > - Suspend/resume are no longer exported from the core. > > > > > > Changes in v5: > > > - Add shutdown_tail op and use it in ACPI. > > > - Added mention of i2c-hid in the yaml itself as per Rob. > > > - Adjusted subject as per Rob. > > > - i2chid_subclass_data => i2chid_ops. > > > - power_up_device => power_up (same with power_down). > > > - subclass => ops. > > > > > > Changes in v4: > > > - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. > > > - Fully rejigger so ACPI and OF are full subclasses. > > > - Totally redid based on the new subclass system. > > > > > > Changes in v3: > > > - Fixed compatible in example. > > > - Removed Benjamin as a maintainer. > > > - Rework to use subclassing. > > > - Updated description. > > > > > > Changes in v2: > > > - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. > > > - Get timings based on the compatible string. > > > - Use a separate compatible string for this new touchscreen. > > > > > > Douglas Anderson (4): > > > HID: i2c-hid: Reorganize so ACPI and OF are separate modules > > > arm64: defconfig: Update config names for i2c-hid rejigger > > > dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix > > > GT7375P > > > HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core > > > > I think this series is ready to land. The "defconfig" has a trivial > > conflict with commit 74b87103b3d0 ("arm64: defconfig: Enable HID > > multitouch") against linuxnext, but it's so simple that hopefully > > folks will be OK with that when it lands. > > > > Please let me know if there's anything else you need me to do. :-) > > > > I wanted to apply the series yesterday, but for these kinds of changes > I like giving it a spin on actual hardware. Turns out that my XPS-13 > can not boot to v5.11-rc2, which makes testing the new branch slightly > more difficult. > > I'll give it a spin next week, but I think I should be able to land it for 5.12. > > Regarding the defconfig conflict, no worries, we can handle it with > Stephen and Linus. > After 2 full kernel bisects (I messed up the first because I am an idiot and inverted good and bad after the first reboot), I found my culprit, and I was able to test the series today. The series works fine regarding enumeration and removing of devices, but it prevents my system from being suspended. If I rmmod i2c-hid-acpi, suspend works fine, but if it is present, it immediately comes back, which makes me think that something must be wrong. I also just reverted the series and confirmed that suspend/resume now works, meaning that patch 1/4 needs to be checked. Cheers, Benjamin