linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] be2net: Fix an error handling path in 'be_probe()'
@ 2021-06-16 18:43 Christophe JAILLET
  2021-06-17  4:37 ` Somnath Kotur
  2021-06-17 18:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2021-06-16 18:43 UTC (permalink / raw)
  To: ajit.khaparde, sriharsha.basavapatna, somnath.kotur, davem, kuba,
	sathya.perla
  Cc: netdev, linux-kernel, kernel-janitors, Christophe JAILLET

If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: d6b6d9877878 ("be2net: use PCIe AER capability")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index b6eba29d8e99..7968568bbe21 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -5897,6 +5897,7 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
 unmap_bars:
 	be_unmap_pci_bars(adapter);
 free_netdev:
+	pci_disable_pcie_error_reporting(pdev);
 	free_netdev(netdev);
 rel_reg:
 	pci_release_regions(pdev);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] be2net: Fix an error handling path in 'be_probe()'
  2021-06-16 18:43 [PATCH] be2net: Fix an error handling path in 'be_probe()' Christophe JAILLET
@ 2021-06-17  4:37 ` Somnath Kotur
  2021-06-17 18:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Somnath Kotur @ 2021-06-17  4:37 UTC (permalink / raw)
  To: christophe.jaillet
  Cc: Ajit Kumar Khaparde, Sriharsha Basavapatna, davem, kuba,
	sathya.perla, netdev, linux-kernel, kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Thu, Jun 17, 2021 at 12:13 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
>
> Fixes: d6b6d9877878 ("be2net: use PCIe AER capability")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/ethernet/emulex/benet/be_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index b6eba29d8e99..7968568bbe21 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -5897,6 +5897,7 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
>  unmap_bars:
>         be_unmap_pci_bars(adapter);
>  free_netdev:
> +       pci_disable_pcie_error_reporting(pdev);
>         free_netdev(netdev);
>  rel_reg:
>         pci_release_regions(pdev);
> --
> 2.30.2
>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] be2net: Fix an error handling path in 'be_probe()'
  2021-06-16 18:43 [PATCH] be2net: Fix an error handling path in 'be_probe()' Christophe JAILLET
  2021-06-17  4:37 ` Somnath Kotur
@ 2021-06-17 18:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-17 18:30 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: ajit.khaparde, sriharsha.basavapatna, somnath.kotur, davem, kuba,
	sathya.perla, netdev, linux-kernel, kernel-janitors

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 16 Jun 2021 20:43:37 +0200 you wrote:
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
> 
> Fixes: d6b6d9877878 ("be2net: use PCIe AER capability")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> [...]

Here is the summary with links:
  - be2net: Fix an error handling path in 'be_probe()'
    https://git.kernel.org/netdev/net/c/c19c8c0e666f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-17 18:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 18:43 [PATCH] be2net: Fix an error handling path in 'be_probe()' Christophe JAILLET
2021-06-17  4:37 ` Somnath Kotur
2021-06-17 18:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).