From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
To: tanmay@codeaurora.org
Cc: Stephen Boyd <swboyd@chromium.org>,
DTML <devicetree@vger.kernel.org>,
aravindh@codeaurora.org, MSM <linux-arm-msm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Rob Clark <robdclark@gmail.com>, Rob Herring <robh+dt@kernel.org>,
Sean Paul <seanpaul@chromium.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
freedreno <freedreno@lists.freedesktop.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on
Date: Mon, 15 Jun 2020 17:04:57 -0600 [thread overview]
Message-ID: <CAOCk7NrX9Lk6GQKXcFMd1CHHu7CjVg7hUAwt1LyNFdVHHGPO-g@mail.gmail.com> (raw)
In-Reply-To: <1eda01da33b620ddee5162be3326853f@codeaurora.org>
On Mon, Jun 15, 2020 at 4:51 PM <tanmay@codeaurora.org> wrote:
>
> On 2020-06-12 16:26, Stephen Boyd wrote:
>
> Thanks for reviews Stephen.
>
> > Quoting Tanmay Shah (2020-06-11 18:50:25)
> >> These patches add support for Display-Port driver on SnapDragon
> >> hardware. It adds
> >> DP driver and DP PLL driver files along with the needed device-tree
> >> bindings.
> >>
> >> The block diagram of DP driver is shown below:
> >>
> >>
> >> +-------------+
> >> |DRM FRAMEWORK|
> >> +------+------+
> >> |
> >> +----v----+
> >> | DP DRM |
> >> +----+----+
> >> |
> >> +----v----+
> >> +------------+| DP +----------++------+
> >> + +---+| DISPLAY |+---+ | |
> >> | + +-+-----+-+ | | |
> >> | | | | | | |
> >> | | | | | | |
> >> | | | | | | |
> >> v v v v v v v
> >> +------+ +------+ +---+ +----+ +----+ +---+ +-----+
> >> | DP | | DP | |DP | | DP | | DP | |DP | | DP |
> >> |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER|
> >> +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+
> >> | | |
> >> +--v---+ +v-----v+
> >> |DEVICE| | DP |
> >> | TREE | |CATALOG|
> >> +------+ +---+---+
> >> |
> >> +---v----+
> >> |CTRL/PHY|
> >> | HW |
> >> +--------+
> >>
> >
> > I've never seen a block diagram for a driver before...
> >
> It is here for v5. https://patchwork.freedesktop.org/series/74312/
I think Stephen is nitpicking your wording, and you seem to not be
understanding his comment. I'm sorry if I am mistaken.
The "DP driver" would seem to refer to the linux software driver you
are proposing patches for, however this diagram looks like a hardware
diagram of the various hardware blocks that the Linux driver code (the
"DP driver") is expected to interact with. I believe you should
re-word "The block diagram of DP driver is shown below:" to be more
specific of what you are describing with your figure. IE your words
say this is a block diagram of the software, when it looks like it is
a block diagram of the hardware.
next prev parent reply other threads:[~2020-06-15 23:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 1:50 [PATCH v6 0/5] Add support for DisplayPort driver on Tanmay Shah
2020-06-12 1:50 ` [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon Tanmay Shah
2020-06-12 16:21 ` Rob Herring
2020-06-16 11:15 ` Stephen Boyd
2020-06-17 15:38 ` Rob Herring
2020-06-12 1:50 ` [PATCH v6 2/5] drm: add constant N value in helper file Tanmay Shah
2020-06-12 1:50 ` [PATCH v6 3/5] drm/msm/dp: add displayPort driver support Tanmay Shah
2020-06-12 1:50 ` [PATCH v6 4/5] drm/msm/dp: add support for DP PLL driver Tanmay Shah
2020-06-12 1:50 ` [PATCH v6 5/5] drm/msm/dpu: add display port support in DPU Tanmay Shah
2020-06-12 23:26 ` [PATCH v6 0/5] Add support for DisplayPort driver on Stephen Boyd
2020-06-15 22:51 ` tanmay
2020-06-15 23:04 ` Jeffrey Hugo [this message]
2020-06-15 23:36 ` [Freedreno] " tanmay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOCk7NrX9Lk6GQKXcFMd1CHHu7CjVg7hUAwt1LyNFdVHHGPO-g@mail.gmail.com \
--to=jeffrey.l.hugo@gmail.com \
--cc=abhinavk@codeaurora.org \
--cc=aravindh@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
--cc=tanmay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).