From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Jeffrey Hugo <jhugo@codeaurora.org>,
David Brown <david.brown@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
MSM <linux-arm-msm@vger.kernel.org>,
linux-clk@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 0/6] MSM8998 Multimedia Clock Controller
Date: Fri, 7 Jun 2019 15:31:13 -0600 [thread overview]
Message-ID: <CAOCk7NrnnUzaXtnRvH0pHyHha4sTQDQCRoVPPatHfgVuEPZr0Q@mail.gmail.com> (raw)
In-Reply-To: <20190607203838.1361E208C3@mail.kernel.org>
On Fri, Jun 7, 2019 at 2:38 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Jeffrey Hugo (2019-05-21 07:52:28)
> > On 5/21/2019 8:44 AM, Jeffrey Hugo wrote:
> > > The multimedia clock controller (mmcc) is the main clock controller for
> > > the multimedia subsystem and is required to enable things like display and
> > > camera.
> >
> > Stephen, I think this series is good to go, and I have display/gpu stuff
> > I'm polishing that will depend on this. Would you kindly pickup patches
> > 1, 3, 4, and 5 for 5.3? I can work with Bjorn to pick up patches 2 and 6.
> >
>
> If I apply patch 3 won't it break boot until patch 2 is also in the
> tree? That seems to imply that I'll break bisection, and we have
> kernelci boot testing clk-next so this will probably set off alarms
> somewhere.
Yes, it'll break boot. Maybe you and Bjorn can make a deal? (more below)
Doesn't look like kernelci is running tests on 8998 anymore, so maybe
no one will complain? As far as I am aware, Marc, Lee, Bjorn, and I
are the only ones whom care about 8998 presently, and I think we are
all good with a temporary breakage in order to get this basic
functionality in since the platform isn't really well supported yet.
>
> I thought we had some code that got removed that was going to make the
> transition "seamless" in the sense that it would search the tree for an
> RPM clk controller and then not add the XO fixed factor clk somehow.
> See commit 54823af9cd52 ("clk: qcom: Always add factor clock for xo
> clocks") for the code that we removed. So ideally we do something like
> this too, but now we search for a property on the calling node to see if
> the XO clk is there?
>
Trying to remember back a bit.
I don't think its possible. Maybe I'm wrong. I didn't see a solution
to the below:
How does GCC know the following?
-RPMCC is compiled in the build (I guess this can be assumed)
-RPMCC has probed
-RPMCC is not and will not be providing XO
next prev parent reply other threads:[~2019-06-07 21:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 14:44 [PATCH v4 0/6] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-05-21 14:46 ` [PATCH v4 1/6] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-06-06 23:29 ` Stephen Boyd
2019-05-21 14:47 ` [PATCH v4 2/6] arm64: dts: msm8998: Add xo clock to gcc node Jeffrey Hugo
2019-05-21 14:48 ` [PATCH v4 3/6] clk: qcom: smd: Add XO clock for MSM8998 Jeffrey Hugo
2019-05-21 14:48 ` [PATCH v4 4/6] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-05-21 14:48 ` [PATCH v4 5/6] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-05-21 14:49 ` [PATCH v4 6/6] arm64: dts: qcom: msm8998: Add mmcc node Jeffrey Hugo
2019-05-21 14:52 ` [PATCH v4 0/6] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-06-07 20:38 ` Stephen Boyd
2019-06-07 21:31 ` Jeffrey Hugo [this message]
2019-06-07 23:18 ` Stephen Boyd
2019-06-11 20:14 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOCk7NrnnUzaXtnRvH0pHyHha4sTQDQCRoVPPatHfgVuEPZr0Q@mail.gmail.com \
--to=jeffrey.l.hugo@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).