From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752771AbaINP6P (ORCPT ); Sun, 14 Sep 2014 11:58:15 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:36432 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752681AbaINP6M (ORCPT ); Sun, 14 Sep 2014 11:58:12 -0400 MIME-Version: 1.0 X-Originating-IP: [2001:470:8:ee7:5dd:182c:39b0:bd87] In-Reply-To: <20140914101821.3745.21235.stgit@localhost> References: <20140914100545.3745.23394.stgit@localhost> <20140914101821.3745.21235.stgit@localhost> From: Peter Foley Date: Sun, 14 Sep 2014 11:57:51 -0400 Message-ID: Subject: Re: [PATCH 1/3] kbuild: Make targets names tree-wide unique on x86 To: Kirill Tkhai Cc: Michal Marek , arnd@arndb.de, linux-kbuild@vger.kernel.org, gregkh@linuxfoundation.org, LKML , oleg@redhat.com, grant.likely@secretlab.ca, ebiederm@xmission.com, Andrew Morton , ktkhai@parallels.com, Sam Ravnborg Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 14, 2014 at 6:18 AM, Kirill Tkhai wrote: > diff --git a/init/Makefile b/init/Makefile > index 7bc47ee..566a9ff 100644 > --- a/init/Makefile > +++ b/init/Makefile > @@ -2,23 +2,28 @@ > # Makefile for the linux kernel. > # > > -obj-y := main.o version.o mounts.o > +obj-y := main.o version.o do_mounts.o > + > ifneq ($(CONFIG_BLK_DEV_INITRD),y) > obj-y += noinitramfs.o > else > -obj-$(CONFIG_BLK_DEV_INITRD) += initramfs.o > +obj-y += initramfs.o do_mounts_initrd.o > +endif > + > +ifeq ($(CONFIG_BLK_DEV_RAM),y) > +obj-y += do_mounts_rd.o > endif > + > +ifeq ($(CONFIG_BLK_DEV_MD),y) > +obj-y += do_mounts_md.o > +endif > + > obj-$(CONFIG_GENERIC_CALIBRATE_DELAY) += calibrate.o > > ifneq ($(CONFIG_ARCH_INIT_TASK),y) > obj-y += init_task.o > endif > > -mounts-y := do_mounts.o > -mounts-$(CONFIG_BLK_DEV_RAM) += do_mounts_rd.o > -mounts-$(CONFIG_BLK_DEV_INITRD) += do_mounts_initrd.o > -mounts-$(CONFIG_BLK_DEV_MD) += do_mounts_md.o > - Can't you keep the obj-$(CONFIG_*) syntax? e.g. obj-$(CONFIG_BLK_DEV_RAM) += do_mounts_rd.o