From: Philippe Ombredanne <pombredanne@nexb.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: James Hogan <james.hogan@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/5] MIPS: Loongson64: lemote-2f move ec_kb3310b.h to include dir and clean up
Date: Sat, 9 Dec 2017 09:29:10 +0100 [thread overview]
Message-ID: <CAOFm3uEVduGvpWQNRofAe5_Lb01g+YZSuoaikq1-PPjaUS27FQ@mail.gmail.com> (raw)
In-Reply-To: <20171209064953.8984-3-jiaxun.yang@flygoat.com>
Dea Jiaxun,
On Sat, Dec 9, 2017 at 7:49 AM, Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> To operate EC from platform driver, this head file need able to be include
> from anywhere. This patch just move ec_kb3310b.h to include dir and
> clean up ec_kb3310b.h.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> arch/mips/include/asm/mach-loongson64/ec_kb3310b.h | 170 +++++++++++++++++++
> arch/mips/loongson64/lemote-2f/ec_kb3310b.c | 2 +-
> arch/mips/loongson64/lemote-2f/ec_kb3310b.h | 188 ---------------------
> arch/mips/loongson64/lemote-2f/pm.c | 4 +-
> arch/mips/loongson64/lemote-2f/reset.c | 4 +-
> 5 files changed, 175 insertions(+), 193 deletions(-)
> create mode 100644 arch/mips/include/asm/mach-loongson64/ec_kb3310b.h
> delete mode 100644 arch/mips/loongson64/lemote-2f/ec_kb3310b.h
>
> diff --git a/arch/mips/include/asm/mach-loongson64/ec_kb3310b.h b/arch/mips/include/asm/mach-loongson64/ec_kb3310b.h
> new file mode 100644
> index 000000000000..2e8690532ea5
> --- /dev/null
> +++ b/arch/mips/include/asm/mach-loongson64/ec_kb3310b.h
> @@ -0,0 +1,170 @@
> +/*
> + * KB3310B Embedded Controller
> + *
> + * Copyright (C) 2008 Lemote Inc.
> + * Author: liujl <liujl@lemote.com>, 2008-03-14
> + * Copyright (C) 2009 Lemote Inc.
> + * Author: Wu Zhangjin <wuzhangjin@gmail.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */
Have you considered using the new SPDX ids instead of this fine but
long license boilerplate?
That would be very gentle of you if you did!
You can check Thomas documentation patches, as well as Linus comments
on the topic.
--
Cordially
Philippe Ombredanne
next prev parent reply other threads:[~2017-12-09 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 6:49 [PATCH v4 0/5] add Lemote YeeLoong Laptop support Jiaxun Yang
2017-12-09 6:49 ` [PATCH v4 1/5] MIPS: Lonngson64: Copy kernel command line from arcs_cmdline Jiaxun Yang
2017-12-09 6:49 ` [PATCH v4 2/5] MIPS: Loongson64: lemote-2f move ec_kb3310b.h to include dir and clean up Jiaxun Yang
2017-12-09 8:29 ` Philippe Ombredanne [this message]
2017-12-09 6:49 ` [PATCH v4 3/5] MIPS: Loongson64: Yeeloong add platform driver Jiaxun Yang
2017-12-09 6:49 ` [PATCH v4 4/5] MIPS: Loongson64: Load platform device during boot Jiaxun Yang
2017-12-09 6:49 ` [PATCH v4 5/5] MAINTAINERS: Add entry for Lemote YeeLoong Extra Driver Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOFm3uEVduGvpWQNRofAe5_Lb01g+YZSuoaikq1-PPjaUS27FQ@mail.gmail.com \
--to=pombredanne@nexb.com \
--cc=james.hogan@mips.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).