From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933302AbeE2LXH (ORCPT ); Tue, 29 May 2018 07:23:07 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:39944 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932949AbeE2LXF (ORCPT ); Tue, 29 May 2018 07:23:05 -0400 X-Google-Smtp-Source: ADUXVKI74yemu+K9kluOhjN8ujp+F0ygcNDcHlY0WnUicjCe5toexYjA3EIRQ33FMuDFRfx3W90OPvEMUHmb5jMlXGw= MIME-Version: 1.0 In-Reply-To: <2775439f-a37a-3118-3532-a4c2260db53e@linaro.org> References: <1527030306-3791-1-git-send-email-festevam@gmail.com> <1527030306-3791-2-git-send-email-festevam@gmail.com> <2775439f-a37a-3118-3532-a4c2260db53e@linaro.org> From: Philippe Ombredanne Date: Tue, 29 May 2018 13:22:23 +0200 Message-ID: Subject: Re: [PATCH 2/4] clocksource: timer-imx-gpt: Switch to SPDX identifier To: Daniel Lezcano Cc: Fabio Estevam , Thomas Gleixner , LKML , Fabio Estevam Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On Wed, May 23, 2018 at 10:06 AM, Daniel Lezcano wrote: > On 23/05/2018 01:05, Fabio Estevam wrote: >> From: Fabio Estevam >> >> Adopt the SPDX license identifier headers to ease license compliance >> management. >> >> Signed-off-by: Fabio Estevam >> --- >> drivers/clocksource/timer-imx-gpt.c | 26 ++++++-------------------- >> 1 file changed, 6 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c >> index b63b834..165fbbb 100644 >> --- a/drivers/clocksource/timer-imx-gpt.c >> +++ b/drivers/clocksource/timer-imx-gpt.c >> @@ -1,23 +1,9 @@ >> -/* >> - * Copyright (C) 2000-2001 Deep Blue Solutions >> - * Copyright (C) 2002 Shane Nay (shane@minirl.com) >> - * Copyright (C) 2006-2007 Pavel Pisa (ppisa@pikron.com) >> - * Copyright (C) 2008 Juergen Beisert (kernel@pengutronix.de) >> - * >> - * This program is free software; you can redistribute it and/or >> - * modify it under the terms of the GNU General Public License >> - * as published by the Free Software Foundation; either version 2 >> - * of the License, or (at your option) any later version. >> - * This program is distributed in the hope that it will be useful, >> - * but WITHOUT ANY WARRANTY; without even the implied warranty of >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> - * GNU General Public License for more details. >> - * >> - * You should have received a copy of the GNU General Public License >> - * along with this program; if not, write to the Free Software >> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, >> - * MA 02110-1301, USA. >> - */ >> +// SPDX-License-Identifier: GPL-2.0+ >> +// >> +// Copyright (C) 2000-2001 Deep Blue Solutions >> +// Copyright (C) 2002 Shane Nay (shane@minirl.com) >> +// Copyright (C) 2006-2007 Pavel Pisa (ppisa@pikron.com) >> +// Copyright (C) 2008 Juergen Beisert (kernel@pengutronix.de) > > Hi Philippe, > > I went through the code and didn't find any information about the format > of the lines following the SPDX, it seems it is relatively free. > > Can you confirm the above changes are ok ? This looks fine to me especially if this all you have in terms of top level comment. (e.g. license then copyrights) Some may not agree with me on using C++ style comments beyond the SPDX license line though ;) -- Cordially Philippe Ombredanne