From: Philippe Ombredanne <pombredanne@nexb.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
netdev@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev
Date: Tue, 20 Feb 2018 08:45:39 +0100 [thread overview]
Message-ID: <CAOFm3uFjoR+qpOR0tHUk78h4BA-qeweoqs3+y_ut==Q34V-0Sw@mail.gmail.com> (raw)
In-Reply-To: <20180216170033.3834-2-mdf@kernel.org>
Hi Moritz,
On Fri, Feb 16, 2018 at 6:00 PM, Moritz Fischer <mdf@kernel.org> wrote:
> Add support for the National Instruments XGE 1/10G network device.
>
> It uses the EEPROM on the board via NVMEM.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
<snip>
> --- /dev/null
> +++ b/drivers/net/ethernet/ni/nixge.c
> @@ -0,0 +1,1352 @@
> +// SPDX-License-Identifier: GPL-2.0
<snip>
> +MODULE_LICENSE("GPL");
This does not match your license above. Per module.h "GPL" would mean "GPL-2.0+"
Can you use one or the other an\d ensure both of these are in sync?
--
Cordially
Philippe Ombredanne
next prev parent reply other threads:[~2018-02-20 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 17:00 [PATCH v3 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev Moritz Fischer
2018-02-16 17:00 ` [PATCH v3 2/2] net: ethernet: nixge: Add support " Moritz Fischer
2018-02-16 18:17 ` Andrew Lunn
2018-02-20 7:45 ` Philippe Ombredanne [this message]
2018-02-19 20:16 ` [PATCH v3 1/2] dt-bindings: net: Add bindings " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOFm3uFjoR+qpOR0tHUk78h4BA-qeweoqs3+y_ut==Q34V-0Sw@mail.gmail.com' \
--to=pombredanne@nexb.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).