From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbdLGVVe (ORCPT ); Thu, 7 Dec 2017 16:21:34 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:40392 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350AbdLGVVb (ORCPT ); Thu, 7 Dec 2017 16:21:31 -0500 X-Google-Smtp-Source: AGs4zMYmZoNo8PST7z47g+KAiyQI9ulVqtMcwSarjT31jLMUrDaYJ5q0uajGVDRijhi2kPEF7fIWa8D5W6NySUVGqn8= MIME-Version: 1.0 In-Reply-To: References: <20171205010438.5773-1-brijesh.singh@amd.com> <20171205010438.5773-13-brijesh.singh@amd.com> From: Philippe Ombredanne Date: Thu, 7 Dec 2017 22:20:49 +0100 Message-ID: Subject: Re: [Part2 PATCH v9 12/38] crypto: ccp: Add Platform Security Processor (PSP) device support To: Brijesh Singh Cc: kvm@vger.kernel.org, LKML , x86@kernel.org, bp@alien8.de, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Borislav Petkov , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 7, 2017 at 9:21 PM, Brijesh Singh wrote: > > > On 12/06/2017 03:10 PM, Philippe Ombredanne wrote:>> diff --git > a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c >>> >>> new file mode 100644 >>> index 000000000000..b5789f878560 >>> --- /dev/null >>> +++ b/drivers/crypto/ccp/psp-dev.c >>> @@ -0,0 +1,105 @@ >>> +/* >>> + * AMD Platform Security Processor (PSP) interface >>> + * >>> + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc. >>> + * >>> + * Author: Brijesh Singh >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License version 2 as >>> + * published by the Free Software Foundation. >>> + */ >> >> >> Dear Brijesh, >> >> Have you considered using the new SPDX license ids instead? >> >> This would come out this way: >>> >>> +// SDPX-License-Identifier: GPL-2.0 >>> +/* >>> + * AMD Platform Security Processor (PSP) interface >>> + * >>> + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc. >>> + * >>> + * Author: Brijesh Singh >>> + */ >> >> >> It is much cleaner and simpler, right? >> >> For the C++ comment style and first line placement, please see Thomas >> (tlgx) doc patches and Linus posts explaining his rationale of why he >> wants it this way. >> It would be awesome if this could be applied to all AMD contributions btw! >> > > Hi Philippe, > > I was not aware of SPDX identifier, If v10 is needed for SEV series then I > will certainly update the patches to use SPDX license identifier. thanks Brijesh, that's very kind of you! -- Cordially Philippe Ombredanne