Re: [PATCH] riscv/ftrace: Add basic support

From: Philippe Ombredanne <pombredanne@nexb.com>
To: Alan Kao <nonerkao@gmail.com>
Cc: Palmer Dabbelt <palmer@sifive.com>, Albert Ou <albert@sifive.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	patches@groups.riscv.org, Ingo Molnar <mingo@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Alan Kao <alankao@andestech.com>
Subject: Re: [PATCH] riscv/ftrace: Add basic support
Date: Thu, 30 Nov 2017 12:31:53 +0100	[thread overview]
Message-ID: <CAOFm3uH0H-12RwoP5OUvBGb-5V-VjdQ58_98RttsyjpS_gtC1g@mail.gmail.com> (raw)
In-Reply-To: <20171130085335.7949-1-alankao@andestech.com>

On Thu, Nov 30, 2017 at 9:53 AM, Alan Kao <nonerkao@gmail.com> wrote:
[]
> diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h
> new file mode 100644
> index 000000000000..38beadb07ad5
> --- /dev/null
> +++ b/arch/riscv/include/asm/ftrace.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2017 Andes Technology Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */

You may want to use the new SPDX ids here instead?
e.g.
> +// SPDX-License-Identifer: GPL-2.0
> +// Copyright (C) 2017 Andes Technology Corporation

Neater and simpler?
See Linus posts on the topic of comment styles too BTW

-- 
Cordially
Philippe Ombredanne