From: Alan Cooper <alcooperx@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>,
": Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"BCM Kernel Feedback" <bcm-kernel-feedback-list@broadcom.com>,
"Chunfeng Yun" <chunfeng.yun@mediatek.com>,
DTML <devicetree@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"USB list" <linux-usb@vger.kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Mathias Nyman" <mathias.nyman@intel.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: Add Broadcom STB USB support
Date: Wed, 8 Apr 2020 09:13:45 -0400 [thread overview]
Message-ID: <CAOGqxeWuP5c2VtA5qHertbwzKrBjEA2Bo4ds_H+vqQ=h_zABEg@mail.gmail.com> (raw)
In-Reply-To: <7e980e08-bc4c-aad5-fce0-0133e4e479f8@gmail.com>
Sending again in plain text.
On Tue, Apr 7, 2020 at 4:28 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> On 3/30/2020 8:40 AM, Rob Herring wrote:
> > On Fri, 27 Mar 2020 16:47:08 -0400, Al Cooper wrote:
> >> Add DT bindings for Broadcom STB USB EHCI and XHCI drivers.
> >>
> >> NOTE: The OHCI driver is not included because it uses the generic
> >> platform driver.
> >>
> >> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> >> ---
> >> .../bindings/usb/brcm,bcm7445-ehci.yaml | 61 +++++++++++++++++++
> >> .../devicetree/bindings/usb/usb-xhci.txt | 1 +
> >> 2 files changed, 62 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.example.dt.yaml: ehci@f0b00300: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> This warning does not seem to be legitimate, the 'interrupt-names'
> property is a valid one, where do we update the schema such that it
> knows about it?
It looks like I need to specify it in the specification portion of my
file if I want it in the example, like I did for "clock-names" and
"phy-names".
Since the driver always get the interrupt by index, I'm going to
remove "interrupt-names" from the example.
Al
>
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.example.dt.yaml: ehci@f0b00300: $nodename:0: 'ehci@f0b00300' does not match '^usb(@.*)?'
>
> This one is a legitimate one and should be fixed.
> --
> Florian
>
>
next prev parent reply other threads:[~2020-04-08 13:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 20:47 [PATCH v2 0/4] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's Al Cooper
2020-03-27 20:47 ` [PATCH v2 1/4] dt-bindings: Add Broadcom STB USB support Al Cooper
2020-03-30 15:40 ` Rob Herring
2020-04-07 20:28 ` Florian Fainelli
2020-04-08 13:13 ` Alan Cooper [this message]
2020-04-08 17:24 ` Florian Fainelli
2020-03-27 20:47 ` [PATCH v2 2/4] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's Al Cooper
2020-03-30 2:35 ` Chunfeng Yun
2020-04-06 15:28 ` Alan Cooper
2020-03-31 9:37 ` Mathias Nyman
2020-03-27 20:47 ` [PATCH v2 3/4] usb: ehci: Add new EHCI driver " Al Cooper
2020-03-28 0:38 ` Alan Stern
2020-03-28 20:18 ` Andy Shevchenko
2020-04-06 18:46 ` Alan Cooper
2020-03-27 20:47 ` [PATCH v2 4/4] usb: host: Add ability to build new Broadcom STB USB drivers Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOGqxeWuP5c2VtA5qHertbwzKrBjEA2Bo4ds_H+vqQ=h_zABEg@mail.gmail.com' \
--to=alcooperx@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=j.neuschaefer@gmx.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=robh@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).