From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751245AbdE3I42 (ORCPT ); Tue, 30 May 2017 04:56:28 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:34571 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbdE3I4Y (ORCPT ); Tue, 30 May 2017 04:56:24 -0400 MIME-Version: 1.0 In-Reply-To: References: <1495896375-30855-1-git-send-email-bhumirks@gmail.com> From: Bhumika Goyal Date: Tue, 30 May 2017 14:26:23 +0530 Message-ID: Subject: Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Liam Girdwood , broonie@kernel.org, clemens@ladisch.de, Julia Lawall , linuxppc-dev@lists.ozlabs.org, perex@perex.cz, Johannes Berg , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2017 at 2:24 PM, Takashi Iwai wrote: > On Sat, 27 May 2017 16:46:15 +0200, > Bhumika Goyal wrote: >> >> Declare snd_kcontrol_new structures as const as they are only passed an >> argument to the function snd_ctl_new1. This argument is of type const, >> so snd_kcontrol_new structures having this property can be made const. >> Done using Coccinelle: >> >> @r disable optional_qualifier@ >> identifier x; >> position p; >> @@ >> static struct snd_kcontrol_new x@p={...}; >> >> @ok@ >> identifier r.x; >> position p; >> @@ >> snd_ctl_new1(&x@p,...) >> >> @bad@ >> position p != {r.p,ok.p}; >> identifier r.x; >> @@ >> x@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r.x; >> @@ >> +const >> struct snd_kcontrol_new x; >> >> Cross compiled these files: >> sound/aoa/codecs/tas.c - powerpc >> sound/mips/{hal2.c/sgio2audio.c} - mips >> sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc >> sound/soc/sh/siu_dai.c - sh >> Could not find an architecture to compile sound/sh/aica.c. >> >> Signed-off-by: Bhumika Goyal > > Applied now, as it looks safe enough. But I prefer splitting to > individual patches, so please try to do that at the next time. > > Okay :) Thanks, Bhumika > thanks, > > Takashi