From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753636AbdHUMzT (ORCPT ); Mon, 21 Aug 2017 08:55:19 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:36972 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbdHUMzQ (ORCPT ); Mon, 21 Aug 2017 08:55:16 -0400 MIME-Version: 1.0 In-Reply-To: <1503315792-14837-1-git-send-email-bhumirks@gmail.com> References: <1503315792-14837-1-git-send-email-bhumirks@gmail.com> From: Bhumika Goyal Date: Mon, 21 Aug 2017 18:25:15 +0530 Message-ID: Subject: Re: [PATCH 0/6] drivers: make device_attribute const To: Julia Lawall , rjw@rjwysocki.net, Len Brown , jbacik@fb.com, jikos@kernel.org, benjamin.tissoires@redhat.com, manish.chopra@cavium.com, rahul.verma@cavium.com, Dept-GELinuxNICDev@cavium.com, harish.patil@cavium.com, cascardo@holoscopio.com, don@syst.com.br, dvhart@infradead.org, Andy Shevchenko , sre@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, nbd-general@lists.sourceforge.net, linux-input@vger.kernel.org, netdev@vger.kernel.org, Platform Driver , linux-pm@vger.kernel.org Cc: Bhumika Goyal Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 21, 2017 at 5:13 PM, Bhumika Goyal wrote: > Make these const. Done using Coccinelle. > > @match disable optional_qualifier@ > identifier s; > @@ > static struct device_attribute s = {...}; > > @ref@ > position p; > identifier match.s; > @@ > s@p > > @good1@ > identifier match.s; > expression e1; > position ref.p; > @@ > device_remove_file(e1,&s@p,...) > > @good2@ > identifier match.s; > expression e1; > position ref.p; > @@ > device_create_file(e1,&s@p,...) > > > @bad depends on !good1 && !good2@ > position ref.p; > identifier match.s; > @@ > s@p > > @depends on forall !bad disable optional_qualifier@ > identifier match.s; > @@ > static > + const > struct device_attribute s; > > Bhumika Goyal (6): > ACPI: make device_attribute const > nbd: make device_attribute const > hid: make device_attribute const > qlogic: make device_attribute const > platform/x86: make device_attribute const > power: supply: make device_attribute const > Hello all, The patches are all independent, so please take what seems relevant. Thanks, Bhumika > drivers/acpi/battery.c | 2 +- > drivers/acpi/sbs.c | 2 +- > drivers/block/nbd.c | 2 +- > drivers/hid/hid-core.c | 2 +- > drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 4 ++-- > drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 6 +++--- > drivers/platform/x86/classmate-laptop.c | 6 +++--- > drivers/platform/x86/intel-rst.c | 4 ++-- > drivers/power/supply/olpc_battery.c | 2 +- > 9 files changed, 15 insertions(+), 15 deletions(-) > > -- > 1.9.1 >