From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F20C433E6 for ; Tue, 26 Jan 2021 11:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BEAF23119 for ; Tue, 26 Jan 2021 11:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405507AbhAZLog (ORCPT ); Tue, 26 Jan 2021 06:44:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392224AbhAZLR5 (ORCPT ); Tue, 26 Jan 2021 06:17:57 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7818BC061573 for ; Tue, 26 Jan 2021 03:17:17 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id b26so22191956lff.9 for ; Tue, 26 Jan 2021 03:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pJqpqM3wbkcxWqAe0VwoN7CRJEfVCncbbtbba4P0YSA=; b=hw3DhRDn9hVvc4daS4DVeWwnNPJ43qcUIN2QWA+gf50WILmLqVSXICy7r5oDz9GATm ECIkd4bdQNiivPf3ijI7v4uD+jrBQtDEg59kE01gsnt1PWWcw6U0buLzykzXXNG4REI4 0GZDEuJkpmFTWd6nBzzJSGkI6iH32Wc07L8XVDpMF2OkjY2ESdR2gEjLLW4uA7KOEpmR AEv7CXjcMfJ0OD0n3BxS65Wfgbwe0wRE1w1MnJ2z2su9YhBjULwx1TnYrVOSk2eqG+6w HEQ2kdWFNBLS5tK4HQNC2rhZcdxHgCa1QSd5pJYHnQ1KDL+MWHsXGJBcz51uVQoCQiXd OHxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pJqpqM3wbkcxWqAe0VwoN7CRJEfVCncbbtbba4P0YSA=; b=U2YkqegXXCoiipx1upJvEu2XtgoZBjhE8Sz7+AK5/jPIw9T20vhMoFHyxG/8NOCxsd cg+Wl/O0F0Mk9P1ACz4uFWHGRmQb2PgHHCM3kNZ6lxBirRlCMPp9NEsvMQKO4LyBTLXQ fVj+/PgChhrW7ZyOOtURQunZxZ/3LZHNHgRbF65Xu2mdqY5oQQs7LjAq2yPE2WjLGXUb b0/wNaJRZIgkgyOyDdlN2VhXVIlIfQ2AADNXpkri2dViYL13h5VsRDTNSXictyKfaFjB n5LUUOvaQKs+B4UXJmyrPB5lCk6gdyg79OZQvxlqXDznjPiru84KSAXgPjXQa4lBt9tw O/Zg== X-Gm-Message-State: AOAM533vl+SEQsx1aDOx2EqPPYOVttYiUY1g0f2kZPy7BVpAnQfrPttw HYR/qgE/GhVYUVyrNpptc2F+d2VrJBnhhmV4+2KWzN97 X-Google-Smtp-Source: ABdhPJxU3hj2FF5Ef59xxhwdUjyo3GvwTAUt+FHXSk5+CTSLTpxLfK4jBeA6EZ42XUv6i9hPnC4gUDiyWKXB5lbV6Dc= X-Received: by 2002:a19:341:: with SMTP id 62mr2351893lfd.500.1611659835911; Tue, 26 Jan 2021 03:17:15 -0800 (PST) MIME-Version: 1.0 References: <20210108214313.GA7979@ripley> <20210110153532.GA7264@ripley> <20210110200606.GD7264@ripley> <20210116124856.GA3406@portage> <20210125212917.GA4177@portage> <20210125221701.GA20107@ripley> In-Reply-To: <20210125221701.GA20107@ripley> From: Fabio Estevam Date: Tue, 26 Jan 2021 08:17:04 -0300 Message-ID: Subject: Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD To: Oliver Graute Cc: Thierry Reding , Sam Ravnborg , Marco Felsch , David Airlie , Daniel Vetter , DRI mailing list , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Oliver, On Mon, Jan 25, 2021 at 7:17 PM Oliver Graute wrote: > I would prefer mine, because I got a wrong colored penguin on bootup > with yours :-) I have originally passed .bpc = 8, but looking at the panel datasheet, this should be: .bpc = 6 instead. In your patch, you pass the timing parameters three times, but they are all the same. Usually, it is meant to be: minimal, typical, maximum values.