From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C307CA9EC5 for ; Tue, 29 Oct 2019 10:26:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71D712087E for ; Tue, 29 Oct 2019 10:26:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PVtNfW4X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730350AbfJ2K02 (ORCPT ); Tue, 29 Oct 2019 06:26:28 -0400 Received: from mail-lj1-f175.google.com ([209.85.208.175]:45768 "EHLO mail-lj1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727875AbfJ2K00 (ORCPT ); Tue, 29 Oct 2019 06:26:26 -0400 Received: by mail-lj1-f175.google.com with SMTP id q64so14594167ljb.12; Tue, 29 Oct 2019 03:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XXJ4yTre3lT2Hw451DHGum9ZE/PvKC28ALSpkKaZpzQ=; b=PVtNfW4XijiPFaMmyDWiKYevJ8Rnb+AuMPalMz+XGKSUUDzZGmB19dF+OPd+Cf7t8x AM5X/2XYgMyjwp1lINKaoqB70YPe+4nr9+G+nSi3wK+NxVo1uxLjvDxnqy3yKeBM3Yeb ietayrCkXZH7jE7r/YWqQ2Sb1zpm4jLfOWjwK4Y735P+vNEmyMgeSeT53ClgCeWNojIp m6zx9kwbh1Un8/jIDXYwUJnRnERjsZ5+G1SJRdPGNXWjRIIXM5aLubj8jIm/u9iRUcDW qL6IjUtTSOPdNq8laPS5fNErXTA8OZWpjNE8PQSwFIYEJhNawPFo18szPVc5JR6Bh3Dx slfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XXJ4yTre3lT2Hw451DHGum9ZE/PvKC28ALSpkKaZpzQ=; b=ddiPlUOQwXODtON3W8ExhpOWSAvenqmgkaBLRDitcoTkyTD96BoX772uiGE0TZV1ru 3xyiiMVgubAQeDoe6v2uT1S95eK81XPB7ptTa5b+200KSMtsIupElRC0gG+TVbG04tAA TEMPFoEzPpu8I3683FHi57DT1RHP5kgSjSQyuHViMq+itFfY1fvZ0xeMZXc48sl84ozw AIU1EtEUqPDtRf5Q0437mZvaqQLUlkDgCMD6tnsJfr/yBWvqKEsdri+lfwQXCcYtmac4 Zgu8porYCWSf31QNnBqkVxWmFrAYQFQCFAOS+8lLPSDoG7HpdPqM16lkDTBqS3mzz1sP ++Uw== X-Gm-Message-State: APjAAAV63r3GSQ2yRGyLIrRB0mB/4fo+Qcmx67YBXynGgzr+8Vd2j7ys mWZoTylcpOX6Sf+pNqf8Q6ONvOx510FAcU1UIos= X-Google-Smtp-Source: APXvYqzvkDNma91N0/j+LId1P0ave935Z1civdg7iP4tElQePFdC576p1UJ9upQws10oWtEnYzB9oLjay/5hPxgilts= X-Received: by 2002:a2e:819a:: with SMTP id e26mr2054650ljg.26.1572344784090; Tue, 29 Oct 2019 03:26:24 -0700 (PDT) MIME-Version: 1.0 References: <1572242618-18806-1-git-send-email-Anson.Huang@nxp.com> <1572242618-18806-2-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1572242618-18806-2-git-send-email-Anson.Huang@nxp.com> From: Fabio Estevam Date: Tue, 29 Oct 2019 07:26:25 -0300 Message-ID: Subject: Re: [PATCH RESEND 2/4] thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit To: Anson Huang Cc: "rui.zhang" , Eduardo Valentin , Daniel Lezcano , Amit Kucheria , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Sascha Hauer , Catalin Marinas , will@kernel.org, Leonard Crestez , Abel Vesa , Ping Bai , Daniel Baluta , Li Jun , Bjorn Andersson , Olof Johansson , mripard@kernel.org, Vinod , Jagan Teki , Dinh Nguyen , marcin.juszkiewicz@linaro.org, linux-pm@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anson, On Mon, Oct 28, 2019 at 3:07 AM Anson Huang wrote: > + ret = clk_prepare_enable(tmu->clk); > + if (ret) { > + dev_err(&pdev->dev, "failed to enable tmu clock: %d\n", ret); > + return ret; > + } > + > + tmu->tzd = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, > + tmu, &tmu_tz_ops); > + if (IS_ERR(tmu->tzd)) { > + dev_err(&pdev->dev, > + "failed to register thermal zone sensor: %d\n", ret); You should disable the tmu clock in the error path. > + return PTR_ERR(tmu->tzd);