From: Fabio Estevam <festevam@gmail.com>
To: Lucile Quirion <lucile.quirion@savoirfairelinux.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
kernel@savoirfairelinux.com,
Lucile Quirion <lucile.quirion@gmail.com>
Subject: Re: [PATCH 2/2] ARM: dts: TS-4900: add basic device tree
Date: Fri, 29 Jul 2016 10:38:43 -0300 [thread overview]
Message-ID: <CAOMZO5AxNvQJv+JyfZDhv97FLmXZ8aMhvG8oPh6N4N1Njsci3g@mail.gmail.com> (raw)
In-Reply-To: <1469641982-19558-3-git-send-email-lucile.quirion@savoirfairelinux.com>
Hi Lucile,
This looks good. Only some minor nits:
On Wed, Jul 27, 2016 at 2:53 PM, Lucile Quirion
<lucile.quirion@savoirfairelinux.com> wrote:
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright 2011 Freescale Semiconductor, Inc.
> + * Copyright 2011 Linaro Ltd.
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
If possible, please consider dual GPL/X11 license. Same applies to other files.
> + reg_3p3v: regulator-3p3v {
> + compatible = "regulator-fixed";
> + regulator-name = "3p3v";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
This 'regulator-always-on' can be removed.
> +&i2c1 {
> + status = "okay";
> + clock-frequency = <100000>;
> + pinctrl-names = "default", "gpio";
> + pinctrl-0 = <&pinctrl_i2c1>;
> + pinctrl-1 = <&pinctrl_i2c1_gpio>;
> + scl-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
> + sda-gpios = <&gpio3 28 GPIO_ACTIVE_HIGH>;
Please move 'status = "okay"' line to the end of the properties list.
Same apply to other nodes in this file.
prev parent reply other threads:[~2016-07-29 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 17:53 [PATCH 0/2] Add board support for TS-4900 Lucile Quirion
2016-07-27 17:53 ` [PATCH 1/2] of: documentation: add bindings documentation " Lucile Quirion
2016-07-29 21:29 ` Rob Herring
2016-07-27 17:53 ` [PATCH 2/2] ARM: dts: TS-4900: add basic device tree Lucile Quirion
2016-07-29 13:38 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5AxNvQJv+JyfZDhv97FLmXZ8aMhvG8oPh6N4N1Njsci3g@mail.gmail.com \
--to=festevam@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kernel@savoirfairelinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lucile.quirion@gmail.com \
--cc=lucile.quirion@savoirfairelinux.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).