From: Fabio Estevam <festevam@gmail.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Lucas Stach <l.stach@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
The etnaviv authors <etnaviv@lists.freedesktop.org>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Russell King <linux+etnaviv@armlinux.org.uk>
Subject: Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks
Date: Wed, 13 May 2020 14:09:21 -0300 [thread overview]
Message-ID: <CAOMZO5B582=tZ_YBCyVYFtGh=z5hZKFxP7XoUHEmH3jZsk2uYQ@mail.gmail.com> (raw)
In-Reply-To: <20200513150007.1315395-3-lkundrak@v3.sk>
On Wed, May 13, 2020 at 12:08 PM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> There might be good reasons why the getting a clock failed. To treat the
> clocks as optional we're specifically only interested in ignoring -ENOENT,
> and devm_clk_get_optional() does just that.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index c6dacfe3d321..e7dbb924f576 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1786,26 +1786,26 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
> }
>
> /* Get Clocks: */
> - gpu->clk_reg = devm_clk_get(&pdev->dev, "reg");
> + gpu->clk_reg = devm_clk_get_optional(&pdev->dev, "reg");
> DBG("clk_reg: %p", gpu->clk_reg);
> if (IS_ERR(gpu->clk_reg))
> - gpu->clk_reg = NULL;
> + return err;
>
> - gpu->clk_bus = devm_clk_get(&pdev->dev, "bus");
> + gpu->clk_bus = devm_clk_get_optional(&pdev->dev, "bus");
The binding doc Documentation/devicetree/bindings/gpu/vivante,gc.yaml
says that only the 'reg' clock could be optional, the others are
required.
> DBG("clk_bus: %p", gpu->clk_bus);
> if (IS_ERR(gpu->clk_bus))
> - gpu->clk_bus = NULL;
> + return err;
>
> - gpu->clk_core = devm_clk_get(&pdev->dev, "core");
> + gpu->clk_core = devm_clk_get_optional(&pdev->dev, "core");
> DBG("clk_core: %p", gpu->clk_core);
> if (IS_ERR(gpu->clk_core))
> - gpu->clk_core = NULL;
> + return err;
> gpu->base_rate_core = clk_get_rate(gpu->clk_core);
>
> - gpu->clk_shader = devm_clk_get(&pdev->dev, "shader");
> + gpu->clk_shader = devm_clk_get_optional(&pdev->dev, "shader");
> DBG("clk_shader: %p", gpu->clk_shader);
> if (IS_ERR(gpu->clk_shader))
> - gpu->clk_shader = NULL;
> + return err;
> gpu->base_rate_shader = clk_get_rate(gpu->clk_shader);
>
> /* TODO: figure out max mapped size */
> --
> 2.26.2
>
> _______________________________________________
> etnaviv mailing list
> etnaviv@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/etnaviv
next prev parent reply other threads:[~2020-05-13 17:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 0/3] drm/etnaviv: Clock fixes>
2020-05-13 15:00 ` Lubomir Rintel
2020-05-13 15:00 ` [PATCH 1/3] drm/etnaviv: Fix error path on failure to enable bus clk Lubomir Rintel
2020-05-13 15:00 ` [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks Lubomir Rintel
2020-05-13 16:07 ` Fabio Estevam
2020-05-13 17:09 ` Fabio Estevam [this message]
2020-05-14 2:41 ` Fabio Estevam
2020-05-14 8:18 ` Lucas Stach
2020-05-14 8:27 ` Russell King - ARM Linux admin
2020-05-14 8:40 ` Lucas Stach
2020-05-14 8:53 ` Russell King - ARM Linux admin
2020-05-20 13:38 ` Lubomir Rintel
2020-05-20 14:04 ` Lucas Stach
2020-05-20 15:00 ` Russell King - ARM Linux admin
2020-05-23 10:22 ` Lubomir Rintel
2020-05-13 15:00 ` [PATCH 3/3] drm/etnaviv: Simplify clock enable/disable Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5B582=tZ_YBCyVYFtGh=z5hZKFxP7XoUHEmH3jZsk2uYQ@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=christian.gmeiner@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).