From: Fabio Estevam <festevam@gmail.com>
To: "Oliver Stäbler" <oliver.staebler@bytesatwork.ch>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx8mm: Fix pad control of SD1_DATA0
Date: Tue, 23 Mar 2021 17:28:53 -0300 [thread overview]
Message-ID: <CAOMZO5B_uHS_Z2LuMwHDmn9erORrsrNBMHMjkW-hW+pnfHZThQ@mail.gmail.com> (raw)
In-Reply-To: <20210323201450.12060-1-oliver.staebler@bytesatwork.ch>
Hi Oliver,
On Tue, Mar 23, 2021 at 5:15 PM Oliver Stäbler
<oliver.staebler@bytesatwork.ch> wrote:
>
> Fix address of the pad control register
> (IOMUXC_SW_PAD_CTL_PAD_SD1_DATA0) for SD1_DATA0_GPIO2_IO2. This seems
> to be a typo but it leads to an exception when pinctrl is applied due to
> wrong memory address access.
>
> Signed-off-by: Oliver Stäbler <oliver.staebler@bytesatwork.ch>
I checked in the RM and your patch is correct, thanks:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
I will send a patch fixing imx8mq-pinfunc.h as it has the same error.
next prev parent reply other threads:[~2021-03-23 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 20:14 [PATCH] arm64: dts: imx8mm: Fix pad control of SD1_DATA0 Oliver Stäbler
2021-03-23 20:28 ` Fabio Estevam [this message]
2021-03-24 13:28 ` [PATCH v2] arm64: dts: imx8mm/q: " Oliver Stäbler
2021-03-24 13:37 ` Fabio Estevam
2021-03-27 17:35 ` Rob Herring
2021-03-29 2:25 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5B_uHS_Z2LuMwHDmn9erORrsrNBMHMjkW-hW+pnfHZThQ@mail.gmail.com \
--to=festevam@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.staebler@bytesatwork.ch \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).