linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* regmap: Failed to create debugfs directory
@ 2018-03-01 18:19 Fabio Estevam
  2018-03-01 18:24 ` Mark Brown
  2018-03-01 18:28 ` Fabio Estevam
  0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-03-01 18:19 UTC (permalink / raw)
  To: Mark Brown; +Cc: brgl, david, linux-kernel

Hi,

Running linux-next 20180301 on a imx6q-sabresd the following
regmap-debugfs warnings are seen:

[    0.067965] CPU identified as i.MX6Q, silicon rev 1.2
[    0.083466] vdd1p1: supplied by regulator-dummy
[    0.084768] vdd3p0: supplied by regulator-dummy
[    0.085816] vdd2p5: supplied by regulator-dummy
[    0.109831] (NULL device *): Failed to create debugfs directory
....

[    2.961117] input: EETI eGalax Touch Screen as
/devices/soc0/soc/2100000.aips-bus/21a8000.i2c/i2c-2/2-0004/input/input0
[    2.977027] (NULL device *): Failed to create debugfs directory
[    2.983929] snvs_rtc 20cc000.snvs:snvs-rtc-lp: rtc core: registered
20cc000.snvs:snvs-rtc-lp as rtc0
[    2.993457] i2c /dev entries driver
[    3.002084] (NULL device *): Failed to create debugfs directory
[    3.010452] imx2-wdt 20c0000.wdog: timeout 60 sec (nowayout=0)

I haven't started to debug this yet, but would like to know if anyone
has any ideas?

Thanks,

Fabio Estevam

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: regmap: Failed to create debugfs directory
  2018-03-01 18:19 regmap: Failed to create debugfs directory Fabio Estevam
@ 2018-03-01 18:24 ` Mark Brown
  2018-03-02  0:27   ` Fabio Estevam
  2018-03-01 18:28 ` Fabio Estevam
  1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2018-03-01 18:24 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: brgl, david, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

On Thu, Mar 01, 2018 at 03:19:50PM -0300, Fabio Estevam wrote:
> Hi,
> 
> Running linux-next 20180301 on a imx6q-sabresd the following
> regmap-debugfs warnings are seen:

Is this triggered by 9b947a13e7f6017f18 (regmap: use debugfs even when
no device)?

> 
> [    0.067965] CPU identified as i.MX6Q, silicon rev 1.2
> [    0.083466] vdd1p1: supplied by regulator-dummy
> [    0.084768] vdd3p0: supplied by regulator-dummy
> [    0.085816] vdd2p5: supplied by regulator-dummy
> [    0.109831] (NULL device *): Failed to create debugfs directory
> ....
> 
> [    2.961117] input: EETI eGalax Touch Screen as
> /devices/soc0/soc/2100000.aips-bus/21a8000.i2c/i2c-2/2-0004/input/input0
> [    2.977027] (NULL device *): Failed to create debugfs directory
> [    2.983929] snvs_rtc 20cc000.snvs:snvs-rtc-lp: rtc core: registered
> 20cc000.snvs:snvs-rtc-lp as rtc0
> [    2.993457] i2c /dev entries driver
> [    3.002084] (NULL device *): Failed to create debugfs directory
> [    3.010452] imx2-wdt 20c0000.wdog: timeout 60 sec (nowayout=0)
> 
> I haven't started to debug this yet, but would like to know if anyone
> has any ideas?
> 
> Thanks,
> 
> Fabio Estevam

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: regmap: Failed to create debugfs directory
  2018-03-01 18:19 regmap: Failed to create debugfs directory Fabio Estevam
  2018-03-01 18:24 ` Mark Brown
@ 2018-03-01 18:28 ` Fabio Estevam
  2018-03-05 16:07   ` Mark Brown
  1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2018-03-01 18:28 UTC (permalink / raw)
  To: Mark Brown; +Cc: brgl, david, linux-kernel

On Thu, Mar 1, 2018 at 3:19 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi,
>
> Running linux-next 20180301 on a imx6q-sabresd the following
> regmap-debugfs warnings are seen:
>
> [    0.067965] CPU identified as i.MX6Q, silicon rev 1.2
> [    0.083466] vdd1p1: supplied by regulator-dummy
> [    0.084768] vdd3p0: supplied by regulator-dummy
> [    0.085816] vdd2p5: supplied by regulator-dummy
> [    0.109831] (NULL device *): Failed to create debugfs directory
> ....
>
> [    2.961117] input: EETI eGalax Touch Screen as
> /devices/soc0/soc/2100000.aips-bus/21a8000.i2c/i2c-2/2-0004/input/input0
> [    2.977027] (NULL device *): Failed to create debugfs directory
> [    2.983929] snvs_rtc 20cc000.snvs:snvs-rtc-lp: rtc core: registered
> 20cc000.snvs:snvs-rtc-lp as rtc0
> [    2.993457] i2c /dev entries driver
> [    3.002084] (NULL device *): Failed to create debugfs directory
> [    3.010452] imx2-wdt 20c0000.wdog: timeout 60 sec (nowayout=0)

This only happens when the regmap name is 'dummy'.

[    0.083651] vdd1p1: supplied by regulator-dummy
[    0.084929] vdd3p0: supplied by regulator-dummy
[    0.085974] vdd2p5: supplied by regulator-dummy
[    0.110028] *****regmap name: dummy
[    0.110090] (NULL device *): regmap*** Failed to create debugfs directory


[    3.001355] input: EETI eGalax Touch Screen as
/devices/soc0/soc/2100000.aips-bus/21a8000.i2c/i2c-2/2-0004/input/input0
[    3.016820] *****regmap name: dummy
[    3.020450] (NULL device *): regmap*** Failed to create debugfs directory
[    3.028316] snvs_rtc 20cc000.snvs:snvs-rtc-lp: rtc core: registered
20cc000.snvs:snvs-rtc-lp as rtc0
[    3.037854] i2c /dev entries driver
[    3.046467] *****regmap name: dummy
[    3.050078] (NULL device *): regmap*** Failed to create debugfs directory

How should we treat the dummy regmap entries?

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: regmap: Failed to create debugfs directory
  2018-03-01 18:24 ` Mark Brown
@ 2018-03-02  0:27   ` Fabio Estevam
  2018-03-02 12:35     ` Fabio Estevam
  0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2018-03-02  0:27 UTC (permalink / raw)
  To: Mark Brown; +Cc: brgl, david, linux-kernel

Hi Mark,

On Thu, Mar 1, 2018 at 3:24 PM, Mark Brown <broonie@kernel.org> wrote:

> Is this triggered by 9b947a13e7f6017f18 (regmap: use debugfs even when
> no device)?

Yes, exactly. If I revert this commit the warnings are gone.

Should I send a revert or is there another way to solve it?

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: regmap: Failed to create debugfs directory
  2018-03-02  0:27   ` Fabio Estevam
@ 2018-03-02 12:35     ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-03-02 12:35 UTC (permalink / raw)
  To: Mark Brown; +Cc: brgl, David Lechner, linux-kernel

Hi Mark,

On Thu, Mar 1, 2018 at 9:27 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Mark,
>
> On Thu, Mar 1, 2018 at 3:24 PM, Mark Brown <broonie@kernel.org> wrote:
>
>> Is this triggered by 9b947a13e7f6017f18 (regmap: use debugfs even when
>> no device)?
>
> Yes, exactly. If I revert this commit the warnings are gone.
>
> Should I send a revert or is there another way to solve it?

Does the change below look good?

diff --git a/drivers/base/regmap/regmap-debugfs.c
b/drivers/base/regmap/regmap-debugfs.c
index 7eb512b..018d3a2 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -575,7 +575,8 @@ void regmap_debugfs_init(struct regmap *map, const
char *name)

        map->debugfs = debugfs_create_dir(name, regmap_debugfs_root);
        if (!map->debugfs) {
-               dev_warn(map->dev, "Failed to create debugfs directory\n");
+               if (map->dev)
+                       dev_warn(map->dev, "Failed to create debugfs
directory\n");
                return;
        }

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: regmap: Failed to create debugfs directory
  2018-03-01 18:28 ` Fabio Estevam
@ 2018-03-05 16:07   ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2018-03-05 16:07 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: brgl, david, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

On Thu, Mar 01, 2018 at 03:28:37PM -0300, Fabio Estevam wrote:
> On Thu, Mar 1, 2018 at 3:19 PM, Fabio Estevam <festevam@gmail.com> wrote:

> > Running linux-next 20180301 on a imx6q-sabresd the following
> > regmap-debugfs warnings are seen:

> This only happens when the regmap name is 'dummy'.

> [    0.083651] vdd1p1: supplied by regulator-dummy
> [    0.084929] vdd3p0: supplied by regulator-dummy
> [    0.085974] vdd2p5: supplied by regulator-dummy
> [    0.110028] *****regmap name: dummy
> [    0.110090] (NULL device *): regmap*** Failed to create debugfs directory

Do we know what exactly is creating these debugfs entries?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-03-05 16:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-01 18:19 regmap: Failed to create debugfs directory Fabio Estevam
2018-03-01 18:24 ` Mark Brown
2018-03-02  0:27   ` Fabio Estevam
2018-03-02 12:35     ` Fabio Estevam
2018-03-01 18:28 ` Fabio Estevam
2018-03-05 16:07   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).