From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C9BC2D0C3 for ; Wed, 18 Dec 2019 15:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0AD42465E for ; Wed, 18 Dec 2019 15:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n4CnIRpg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727173AbfLRPJu (ORCPT ); Wed, 18 Dec 2019 10:09:50 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:36110 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726913AbfLRPJt (ORCPT ); Wed, 18 Dec 2019 10:09:49 -0500 Received: by mail-lj1-f194.google.com with SMTP id r19so2540803ljg.3; Wed, 18 Dec 2019 07:09:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HhJbWUsWwTIyi0nz4fJwHURTxI1Rw4XYrR+51bn6K04=; b=n4CnIRpgiWYaPqhrTGDqoNhiTBR0o5Z4TZgEmVJjUqrcxs/eZ/RmRLpYvIVEjSMOuw zj7m3K6IjnEBCb0Znun9ZsDmmSn1LRVTajc0FgbgZMrc6WGWZUMFHAASKtM7AI1xdD+x B0nJEXFCWymrx5jxZ+vCYGBdE/nRahl8x+0BZNk01+p865de/TDTBDKa2Er4pnzvhxN5 4+pmsqRkwZVO5VdTu6YWuFDTYVudquuDrwZkO5oJ4rXj00ugbbpz86t8pTfa/P+Y0w4X BQfClWxwjmtj/ejYcqXHblGAqzIUXUWDmAtlo7XoQtG4Mro9KTRTQm3w/ajdp+uV8l0r NDrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HhJbWUsWwTIyi0nz4fJwHURTxI1Rw4XYrR+51bn6K04=; b=nekby59T0NtauZtOpEYXpBaZMnkGLfTitnriXgRZ8eDMAVKmKrRYuIT5/dEgXMoN/J 67R3Fl/7Dt7dGXISGr9P5IrXmtXi+AlGIwJQf/UntEkUTlUF/wPvuE2C4yy/4DsTKSx1 pYZX8lBgBJrl4NzPwzLt67kzFfb67hlvRb4ElH7u432kDTH6w1mdr1SFaII/YughiNJz 6LqUW8wGXshRqcP+aadZnYMbiG0L5C41t+z19BxxgQEomwWQR7zlXMXlr1TC2Kpx2ylM iLx71TLcsvoMqwRxewsMORXhRktfYanvO/KOcokkLJ5sjQO8GTkrOqNDQbRIgooUaUlm TyjA== X-Gm-Message-State: APjAAAU9MQGjgn4/ZpQLMCAmxASQ4UeQ9hc8jp3C9ZfzdssLbVMDVpQv h847/MZMXI6cN6za2tovO5NHAhxUI0GFkOnMhKY= X-Google-Smtp-Source: APXvYqxcQGEJtnYA9Dox6wkCmoNhgi0nQlVxmrljxdbiXh66FZxbDmoKUQbvXOU6f+M6uubdRb2209sGGo+XVq9qTo4= X-Received: by 2002:a2e:814e:: with SMTP id t14mr2079402ljg.149.1576681787440; Wed, 18 Dec 2019 07:09:47 -0800 (PST) MIME-Version: 1.0 References: <1576672860-14420-1-git-send-email-peng.fan@nxp.com> <20191218145955.GE26938@lunn.ch> In-Reply-To: <20191218145955.GE26938@lunn.ch> From: Fabio Estevam Date: Wed, 18 Dec 2019 12:09:42 -0300 Message-ID: Subject: Re: [PATCH 1/2] pinctrl: mvebu: armada-37xx: use use platform api To: Andrew Lunn Cc: Peng Fan , "jason@lakedaemon.net" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" , "linus.walleij@linaro.org" , "mripard@kernel.org" , "wens@csie.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Wed, Dec 18, 2019 at 12:00 PM Andrew Lunn wrote: > Hi Fabio > > Look closer. This is not about returning an error, it is about > printing an error. > > I think the API could better. A %ie formatter would make a lot of > sense, so avoiding the ERR_PTR(). Yes, I think that returning the error like: dev_err(dev, "Couldn't determine irq count: %d\n", nr_irq_parent); would make the code cleaner. Maybe just a matter of taste though ;-)