From: Fabio Estevam <festevam@gmail.com>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH v6 3/6] power: Add support for DA9150 Fuel-Gauge
Date: Mon, 5 Oct 2015 13:10:12 -0300 [thread overview]
Message-ID: <CAOMZO5BnrNrXnuVOdhtNXsmgtm4KVVzs41g3CfZX9penEHLutg@mail.gmail.com> (raw)
In-Reply-To: <80d467703ba19bef12e9bcdd246e1de7bd33a8b1.1444059987.git.Adam.Thomson.Opensource@diasemi.com>
On Mon, Oct 5, 2015 at 1:03 PM, Adam Thomson
<Adam.Thomson.Opensource@diasemi.com> wrote:
> + /* Register IRQ */
> + irq = platform_get_irq_byname(pdev, "FG");
> + if (irq < 0) {
> + dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
You need to do "ret = irq" here. Otherwise you will return success in irq_fail.
> + goto irq_fail;
next prev parent reply other threads:[~2015-10-05 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 16:03 [PATCH v6 0/6] Add support for DA9150 Fuel-Gauge Adam Thomson
2015-10-05 16:03 ` [PATCH v6 1/6] mfd: da9150: Add support for Fuel-Gauge Adam Thomson
2015-10-05 16:03 ` [PATCH v6 2/6] mfd: da9150: Update DT bindings for Fuel-Gauge support Adam Thomson
2015-10-05 16:03 ` [PATCH v6 3/6] power: Add support for DA9150 Fuel-Gauge Adam Thomson
2015-10-05 16:10 ` Fabio Estevam [this message]
2015-10-06 18:50 ` kbuild test robot
2015-10-05 16:03 ` [PATCH v6 4/6] power: da9150: Add DT bindings documentation for Fuel-Gauge Adam Thomson
2015-10-05 16:03 ` [PATCH v6 5/6] mfd: da9150: Use relative paths in DT bindings document Adam Thomson
2015-10-05 16:03 ` [PATCH v6 6/6] mfd: da9150: Use DEFINE_RES_IRQ_NAMED() help macro for IRQ resource Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5BnrNrXnuVOdhtNXsmgtm4KVVzs41g3CfZX9penEHLutg@mail.gmail.com \
--to=festevam@gmail.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).