From: Fabio Estevam <festevam@gmail.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: "Richard Zhu" <hongxing.zhu@nxp.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
linux-pci@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH 1/6] PCI: imx6: Rename imx6_* with imx_*
Date: Wed, 28 Feb 2024 20:14:16 -0300 [thread overview]
Message-ID: <CAOMZO5C-01=jYbJTgQucfD8+pT-chy4xvQMckUee1O+gtE-0pQ@mail.gmail.com> (raw)
In-Reply-To: <20240227-pci2_upstream-v1-1-b952f8333606@nxp.com>
On Tue, Feb 27, 2024 at 6:47 PM Frank Li <Frank.Li@nxp.com> wrote:
>
> imx6_* actually mean for all imx chips (imx6x, imx7x, imx8x and imx9x).
That's OK. In the kernel, we have lots of examples where the names of
files and functions follow the first chip model.
If this same IP gets used by another SoC in the future that is not
named i.MX, will this driver get renamed again?
> Rename imx6_* with imx_* to avoid confuse.
I don't find it confusing.
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 754 +++++++++++++++++-----------------
> 1 file changed, 377 insertions(+), 377 deletions(-)
I think this pure churn and we should not do the rename as it brings
no benefits.
next prev parent reply other threads:[~2024-02-28 23:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 21:47 [PATCH 0/6] PCI: imx6: rename\clean up and add lut information for imx95 Frank Li
2024-02-27 21:47 ` [PATCH 1/6] PCI: imx6: Rename imx6_* with imx_* Frank Li
2024-02-28 23:14 ` Fabio Estevam [this message]
2024-02-28 23:31 ` Frank Li
2024-02-27 21:47 ` [PATCH 2/6] PCI: imx6: Rename pci-imx6.c and PCI_IMX6 config Frank Li
2024-02-28 23:05 ` Bjorn Helgaas
2024-02-28 23:36 ` Frank Li
2024-02-29 7:29 ` Ahmad Fatoum
2024-03-01 7:16 ` kernel test robot
2024-02-27 21:47 ` [PATCH 3/6] MAINTAINERS: pci: imx: update imx6* to imx* since rename driver file Frank Li
2024-02-27 21:47 ` [PATCH 4/6] PCI: imx: Simplify switch-case logic by involve set_ref_clk callback Frank Li
2024-02-27 21:47 ` [PATCH 5/6] PCI: imx: Simplify switch-case logic by involve core_reset callback Frank Li
2024-02-27 21:47 ` [PATCH 6/6] PCI: imx: Config look up table(LUT) to support MSI ITS and IOMMU for i.MX95 Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5C-01=jYbJTgQucfD8+pT-chy4xvQMckUee1O+gtE-0pQ@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=bpf@vger.kernel.org \
--cc=broonie@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).