From: Fabio Estevam <festevam@gmail.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Mark Brown <broonie@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-spi <linux-spi@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: (EXT) Re: [PATCH] spi-imx: remove num-cs support, set num_chipselect to 4
Date: Fri, 4 Sep 2020 10:57:13 -0300 [thread overview]
Message-ID: <CAOMZO5C7yyA11EOQvU0Fq-uDd5RK-B7WmbtvAy8OtPzfThYXRg@mail.gmail.com> (raw)
In-Reply-To: <e1431dd2653dbffdfec39a2e7167db07836e30ac.camel@ew.tq-group.com>
On Fri, Sep 4, 2020 at 10:02 AM Matthias Schiffer
<matthias.schiffer@ew.tq-group.com> wrote:
> This would make num_chipselect default to 1 again (set by
> __spi_alloc_controller()), breaking every i.MX board that uses more
> than 1 native CS.
Which boards are that? Are you referring to non-DT i.MX boards?
If so, I have sent a patch removing all non-DT i.MX boards.
> I'm aware that using cs-gpios instead of native CS is probably a good
> idea in any case, as the native CS of this SPI controller is kinda
> flaky (and at a glance it looks like all in-tree DTs do this; not sure
> about board files that don't use DTs?), but I'm not convinced that
> breaking native CS support completely is desirable either.
Initial i.MX chips with this SPI IP had issues in using chip-select in
native mode and GPIO chip-select has been used since them.
Do we have i.MX dts that make use of native chip select?
next prev parent reply other threads:[~2020-09-04 13:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 14:40 [PATCH] spi-imx: remove num-cs support, set num_chipselect to 4 Matthias Schiffer
2020-09-04 12:35 ` Fabio Estevam
2020-09-04 13:02 ` (EXT) " Matthias Schiffer
2020-09-04 13:57 ` Fabio Estevam [this message]
2020-09-04 14:34 ` (EXT) " Matthias Schiffer
2020-09-04 15:04 ` Mark Brown
2020-09-04 15:42 ` Fabio Estevam
2020-09-07 7:40 ` (EXT) " Matthias Schiffer
2020-09-13 14:15 ` Fabio Estevam
2020-09-04 13:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5C7yyA11EOQvU0Fq-uDd5RK-B7WmbtvAy8OtPzfThYXRg@mail.gmail.com \
--to=festevam@gmail.com \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).