linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL
@ 2018-06-08 10:19 Philipp Puschmann
  2018-06-08 13:00 ` Fabio Estevam
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Philipp Puschmann @ 2018-06-08 10:19 UTC (permalink / raw)
  To: shawnguo
  Cc: s.hauer, kernel, pp, linux-kernel, fabio.estevam, mturquette,
	sboyd, linux-arm-kernel, linux-clk

q/dl datasheets list the 5th selection value for ck01_sel as
video_27M_clk_root.

By replacing the dummy value we then can set IMX6QDL_CLK_VIDEO_27M
as parent for IMX6QDL_CLK_CKO1_SEL.

Signed-off-by: Philipp Puschmann <pp@emlix.com>
---
 drivers/clk/imx/clk-imx6q.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
index 8d518ad5dc13..7e6a8f079634 100644
--- a/drivers/clk/imx/clk-imx6q.c
+++ b/drivers/clk/imx/clk-imx6q.c
@@ -65,7 +65,7 @@ static const char *ipg_per_sels[] = { "ipg", "osc", };
 static const char *ecspi_sels[] = { "pll3_60m", "osc", };
 static const char *can_sels[] = { "pll3_60m", "osc", "pll3_80m", };
 static const char *cko1_sels[]	= { "pll3_usb_otg", "pll2_bus", "pll1_sys", "pll5_video_div",
-				    "dummy", "axi", "enfc", "ipu1_di0", "ipu1_di1", "ipu2_di0",
+				    "video_27m", "axi", "enfc", "ipu1_di0", "ipu1_di1", "ipu2_di0",
 				    "ipu2_di1", "ahb", "ipg", "ipg_per", "ckil", "pll4_audio_div", };
 static const char *cko2_sels[] = {
 	"mmdc_ch0_axi", "mmdc_ch1_axi", "usdhc4", "usdhc1",
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL
  2018-06-08 10:19 [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL Philipp Puschmann
@ 2018-06-08 13:00 ` Fabio Estevam
  2018-06-11 14:12   ` Philipp Puschmann
  2018-06-29 18:47 ` Stephen Boyd
  2018-06-29 18:48 ` Stephen Boyd
  2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2018-06-08 13:00 UTC (permalink / raw)
  To: Philipp Puschmann
  Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, linux-kernel,
	Fabio Estevam, Michael Turquette, Stephen Boyd,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-clk

Hi Philipp,

On Fri, Jun 8, 2018 at 7:19 AM, Philipp Puschmann <pp@emlix.com> wrote:
> q/dl datasheets list the 5th selection value for ck01_sel as
> video_27M_clk_root.
>
> By replacing the dummy value we then can set IMX6QDL_CLK_VIDEO_27M
> as parent for IMX6QDL_CLK_CKO1_SEL.
>
> Signed-off-by: Philipp Puschmann <pp@emlix.com>

You could still have added my Reviewed-by tag that I sent previously :-)

Here it goes:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

Also in the future, when posting a new version of a patch, please mark
it as such:

[PATCH v2] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL

and write below the --- line what are the changes in this new version.

Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL
  2018-06-08 13:00 ` Fabio Estevam
@ 2018-06-11 14:12   ` Philipp Puschmann
  0 siblings, 0 replies; 5+ messages in thread
From: Philipp Puschmann @ 2018-06-11 14:12 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-kernel, linux-arm-kernel, linux-clk

> Hi Philipp,
> 
> On Fri, Jun 8, 2018 at 7:19 AM, Philipp Puschmann <pp@emlix.com> wrote:
>> q/dl datasheets list the 5th selection value for ck01_sel as
>> video_27M_clk_root.
>>
>> By replacing the dummy value we then can set IMX6QDL_CLK_VIDEO_27M
>> as parent for IMX6QDL_CLK_CKO1_SEL.
>>
>> Signed-off-by: Philipp Puschmann <pp@emlix.com>
> 
> You could still have added my Reviewed-by tag that I sent previously :-)
> 
> Here it goes:
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Also in the future, when posting a new version of a patch, please mark
> it as such:
> 
> [PATCH v2] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL
> 
> and write below the --- line what are the changes in this new version.
> 
> Thanks
> 

Hi Fabio,

thank you for your hints, next time i will do it that way

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL
  2018-06-08 10:19 [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL Philipp Puschmann
  2018-06-08 13:00 ` Fabio Estevam
@ 2018-06-29 18:47 ` Stephen Boyd
  2018-06-29 18:48 ` Stephen Boyd
  2 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2018-06-29 18:47 UTC (permalink / raw)
  To: Philipp Puschmann, shawnguo
  Cc: s.hauer, kernel, pp, linux-kernel, fabio.estevam, mturquette,
	linux-arm-kernel, linux-clk

Quoting Philipp Puschmann (2018-06-08 03:19:24)
> q/dl datasheets list the 5th selection value for ck01_sel as
> video_27M_clk_root.
> 
> By replacing the dummy value we then can set IMX6QDL_CLK_VIDEO_27M
> as parent for IMX6QDL_CLK_CKO1_SEL.
> 
> Signed-off-by: Philipp Puschmann <pp@emlix.com>
> ---

Applied to clk-next


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL
  2018-06-08 10:19 [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL Philipp Puschmann
  2018-06-08 13:00 ` Fabio Estevam
  2018-06-29 18:47 ` Stephen Boyd
@ 2018-06-29 18:48 ` Stephen Boyd
  2 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2018-06-29 18:48 UTC (permalink / raw)
  To: Philipp Puschmann, shawnguo
  Cc: s.hauer, kernel, pp, linux-kernel, fabio.estevam, mturquette,
	linux-arm-kernel, linux-clk

Quoting Philipp Puschmann (2018-06-08 03:19:24)
> q/dl datasheets list the 5th selection value for ck01_sel as
> video_27M_clk_root.
> 
> By replacing the dummy value we then can set IMX6QDL_CLK_VIDEO_27M
> as parent for IMX6QDL_CLK_CKO1_SEL.
> 
> Signed-off-by: Philipp Puschmann <pp@emlix.com>
> ---

Applied to clk-next


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-06-29 18:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-08 10:19 [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL Philipp Puschmann
2018-06-08 13:00 ` Fabio Estevam
2018-06-11 14:12   ` Philipp Puschmann
2018-06-29 18:47 ` Stephen Boyd
2018-06-29 18:48 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).