linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi: spi-fsl-espi: Remove use of %p
@ 2020-08-25  5:08 Chris Packham
  2020-08-25 20:19 ` Mark Brown
  2020-08-25 20:28 ` Fabio Estevam
  0 siblings, 2 replies; 3+ messages in thread
From: Chris Packham @ 2020-08-25  5:08 UTC (permalink / raw)
  To: broonie; +Cc: linux-spi, linux-kernel, Chris Packham

The register offset is already included in the device name so even prior
%p values being hashed printing the base was redundant. Remove the %p
from the dev_info() output.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 drivers/spi/spi-fsl-espi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c
index e60581283a24..7e9b6f8d6243 100644
--- a/drivers/spi/spi-fsl-espi.c
+++ b/drivers/spi/spi-fsl-espi.c
@@ -730,7 +730,7 @@ static int fsl_espi_probe(struct device *dev, struct resource *mem,
 	if (ret < 0)
 		goto err_pm;
 
-	dev_info(dev, "at 0x%p (irq = %u)\n", espi->reg_base, irq);
+	dev_info(dev, "irq = %u\n", irq);
 
 	pm_runtime_mark_last_busy(dev);
 	pm_runtime_put_autosuspend(dev);
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: spi-fsl-espi: Remove use of %p
  2020-08-25  5:08 [PATCH] spi: spi-fsl-espi: Remove use of %p Chris Packham
@ 2020-08-25 20:19 ` Mark Brown
  2020-08-25 20:28 ` Fabio Estevam
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-08-25 20:19 UTC (permalink / raw)
  To: Chris Packham; +Cc: linux-kernel, linux-spi

On Tue, 25 Aug 2020 17:08:56 +1200, Chris Packham wrote:
> The register offset is already included in the device name so even prior
> %p values being hashed printing the base was redundant. Remove the %p
> from the dev_info() output.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-fsl-espi: Remove use of %p
      commit: 9442a12d16a974507738e1ca1bf62e3afa39381b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: spi-fsl-espi: Remove use of %p
  2020-08-25  5:08 [PATCH] spi: spi-fsl-espi: Remove use of %p Chris Packham
  2020-08-25 20:19 ` Mark Brown
@ 2020-08-25 20:28 ` Fabio Estevam
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2020-08-25 20:28 UTC (permalink / raw)
  To: Chris Packham; +Cc: Mark Brown, linux-spi, linux-kernel

On Tue, Aug 25, 2020 at 2:10 AM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
>
> The register offset is already included in the device name so even prior
> %p values being hashed printing the base was redundant. Remove the %p
> from the dev_info() output.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-25 20:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25  5:08 [PATCH] spi: spi-fsl-espi: Remove use of %p Chris Packham
2020-08-25 20:19 ` Mark Brown
2020-08-25 20:28 ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).